Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- **resilience:** restore the expired-connection retry-budget probe in the token-health sweep — the `!isGitHubAccessTokenOnlyConnection` carve-out reintroduced by #11608 contradicted the boundary pinned by #11592, so a GitHub connection parked at `expired` with retry budget remaining was never probed and could never self-heal ([#11592](https://github.com/diegosouzapw/OmniRoute/pull/11592)).
7 changes: 0 additions & 7 deletions src/lib/tokenHealthCheck.ts
Original file line number Diff line number Diff line change
Expand Up @@ -599,13 +599,6 @@ export async function checkConnection(conn) {
const isRecoverableExpiredWithRetryBudget =
conn.testStatus === "expired" &&
conn.lastErrorType !== "account_deactivated" &&
// GitHub access-token-only connections have their own dedicated exemption
// (isRecoverableGithubCopilotNoRefresh above): ONLY the exact
// "no_refresh_token" shape self-heals. An "expired" GitHub connection for a
// different reason (e.g. invalid_grant) is genuinely terminal and must stay
// skipped, otherwise the generic retry-budget exemption below reopens #8182's
// wasted-probe fix for every "expired" GitHub connection.
!isGitHubAccessTokenOnlyConnection(conn) &&
getExpiredRetryCount(conn) < EXPIRED_RETRY_MAX;
const terminalStatuses = new Set(["credits_exhausted", "banned", "expired"]);
if (
Expand Down
Loading