Repository navigation
test(autoCombo): port models_dev_tier #11508 guard from node:test to vitest - #11635
Merged
diegosouzapw merged 1 commit intoAug 26, 2026
Conversation
…ode:test to vitest tests/unit/autoCombo/** is collected exclusively by vitest (vitest.mcp.config.ts include 'tests/unit/autoCombo/**/*.test.ts'; test:unit only globs tests/unit/*.test.ts + dashboard/) and every sibling in that directory imports from 'vitest'. This one file imported describe/it/before from 'node:test' instead, so vitest registered zero suites and failed the whole fast-path job with 'No test suite found' — while the node:test callbacks leaked their own spec output into the vitest log. Port the imports (before -> beforeAll; keep node:assert/strict, runner-agnostic). No assertion changed. Evidence: npm run test:vitest on pristine origin/release/v3.8.51 fails this suite identically (1 failed / 48 passed, 452 tests); after the port: 49 files passed, 457 tests passed.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…ode:test to vitest (diegosouzapw#11635) Merged via /merge-batch (2026-08-26, v3.8.51). Validado com o config correto (`vitest run --config vitest.mcp.config.ts`, que já inclui `tests/unit/autoCombo/**/*.test.ts`): 5/5 testes passando. Obrigado por destravar esse base-red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Vitest (fast-path) base-red on
release/v3.8.51(tracked under #11449; surfaced on PR #11633's run).Root cause
tests/unit/autoCombo/models-dev-tier-11508.test.tsimportsdescribe/it/beforefromnode:test, but the directory is collected exclusively by vitest:vitest.mcp.config.tsincludes"tests/unit/autoCombo/**/*.test.ts".test:unit) only globstests/unit/*.test.ts,tests/unit/dashboard/**, andtests/unit/**/*.test.mjs— it never sees this file.tests/unit/autoCombo/imports from"vitest".Result: vitest collects the file, registers zero suites, and fails the whole job with
No test suite found in file ... models-dev-tier-11508.test.ts, while the node:test callbacks leak their own spec output into the vitest log. The suite has effectively never been counted by either runner.Fix
Port the imports to vitest —
before→beforeAll; keepnode:assert/strict(runner-agnostic). No assertion or seeding logic changed. 2-line diff.Verification
Note: the other failing fast-path job on that run (Docs Gates — provider-count 353→354 drift) is a separate concern and needs its own docs-sync fix.