Skip to content

fix(sse): isolate credential health from model failures - #11628

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.51from
KaspaPulse:fix/home-provider-health-stale-state-20260826
Aug 26, 2026
Merged

diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.51from
KaspaPulse:fix/home-provider-health-stale-state-20260826

Conversation

@KaspaPulse

Copy link
Copy Markdown
Contributor

Summary

  • keep model-not-found, unsupported-model, and model-sync conflicts out of per-credential health
  • preserve genuine 401 and credential-signaled 403 failure tracking for the exact selected key
  • recover only the credential proven healthy by request execution or connection validation, without clearing sibling keys or active quota cooldowns

TDD evidence

Red phase reproduced three failures: genuine 403 credential rejection was ignored, a successful exact-key validation during cooldown left the key warning stale, and primary-key validation cleared sibling-key health.

Green phase:

  • 14 focused regression tests passed
  • 85 directly affected key rotation, 402 protection, model fallback, provider validation, and execution-credential tests passed
  • touched-file ESLint passed
  • Prettier ran on all touched files
  • git diff --check passed
  • npm run typecheck:core passed
  • open-sse project typecheck remains blocked only by inherited errors in src/lib/guardrails/videoBridgeHelpers.ts; that file is unchanged

Build not run: this changes internal health bookkeeping, not a production API contract.

⚠️ base-red inherited: #11449

@KaspaPulse
KaspaPulse marked this pull request as ready for review August 26, 2026 11:06
@KaspaPulse
KaspaPulse force-pushed the fix/home-provider-health-stale-state-20260826 branch from 55c094e to 61395b3 Compare August 26, 2026 11:42
@diegosouzapw
diegosouzapw merged commit 86c03f1 into diegosouzapw:release/v3.8.51 Aug 26, 2026
8 of 16 checks passed
diegosouzapw added a commit that referenced this pull request Aug 26, 2026
…11636)

Merged via /merge-batch (correção de lacuna, 2026-08-26). check:file-size confirmado OK após o rebaseline.
@KaspaPulse
KaspaPulse deleted the fix/home-provider-health-stale-state-20260826 branch August 31, 2026 11:12
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). Boarded no worktree combinado junto com outras ~20 PRs; validação única: typecheck/complexity/cognitive-complexity/changelog-integrity verdes, file-size rebaseado onde necessário (crescimento legítimo), lint com os mesmos 228 achados pré-existentes confirmados via sonda contra o tip puro (não introduzidos por este lote), e 292 testes focados (unit) + 18 (vitest) passando. Obrigado pela contribuição.
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…apw#11631/diegosouzapw#11628 growth (diegosouzapw#11636)

Merged via /merge-batch (correção de lacuna, 2026-08-26). check:file-size confirmado OK após o rebaseline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants