Repository navigation
fix(tailscale): validate ports and quote MSI paths - #11534
Merged
diegosouzapw merged 1 commit intoAug 25, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
pacocartones
force-pushed
the
fix/oss026-tailscale-validation
branch
from
August 25, 2026 15:17
4180b9c to
8ee3985
Compare
diegosouzapw
merged commit Aug 25, 2026
436ce48
into
diegosouzapw:release/v3.8.51
7 of 16 checks passed
This was referenced Aug 25, 2026
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
Validated in a combined 10-PR batch worktree off release/v3.8.51 tip. - Focused test: tests/unit/tailscale-validation.test.ts — 2/2 pass plus 13/13 related Tailscale tests - typecheck:core, file-size, changelog-integrity, complexity, cognitive-complexity gates — all OK - Full-repo lint: 503 pre-existing problems confirmed identical on the pure release/v3.8.51 tip — unrelated to this diff⚠️ base-red inherited: diegosouzapw#11449 Thanks for rejecting out-of-range Tailscale ports and escaping apostrophes before they reach the Windows MSI installer PowerShell command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rejects Tailscale ports outside 1-65535 and escapes apostrophes in Windows MSI paths before embedding them in the PowerShell installer command. Tests: 2/2 focused plus 13/13 Tailscale pass; focused ESLint, build-scope and diff checks pass.⚠️ base-red inherited: #11449.