Skip to content

fix(cli): preserve existing admin password during setup #11522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 1 commit into from
Aug 25, 2026
Merged

fix(cli): preserve existing admin password during setup #11522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bin/cli/commands/setup.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ function wantsProviderSetup(opts) {
return opts.addProvider || Boolean(opts.provider) || Boolean(opts.apiKey);
}

async function resolvePassword(opts, prompt, nonInteractive) {
if (opts.password) return opts.password;
if (process.env.INITIAL_PASSWORD) return process.env.INITIAL_PASSWORD;
async function resolvePassword(opts, prompt, nonInteractive, settings) {
if (opts.password !== undefined) return opts.password;
if (!settings.password && process.env.INITIAL_PASSWORD) return process.env.INITIAL_PASSWORD;
if (nonInteractive) return "";

const answer = await prompt.ask("Set an admin password now? [y/N]", "N");
Expand All @@ -41,9 +41,9 @@ async function resolvePassword(opts, prompt, nonInteractive) {
}

async function setupPassword(db, opts, prompt, nonInteractive) {
const password = await resolvePassword(opts, prompt, nonInteractive);
const settings = getSettings(db);
const password = await resolvePassword(opts, prompt, nonInteractive, settings);
if (!password) {
const settings = getSettings(db);
if (!settings.password) {
updateSettings(db, { requireLogin: false });
}
Expand Down
29 changes: 29 additions & 0 deletions tests/unit/cli-setup-command.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,3 +250,32 @@ test("setup command prioritizes an explicit --password flag over INITIAL_PASSWOR
process.env.INITIAL_PASSWORD = ORIGINAL_INITIAL_PASSWORD;
}
});

test("setup command does not replace an existing password from INITIAL_PASSWORD", async () => {
const ORIGINAL_INITIAL_PASSWORD = process.env.INITIAL_PASSWORD;
await withTempEnv(async (dataDir) => {
const { runSetupCommand } = await import("../../bin/cli/commands/setup.mjs");

await runSetupCommand({ nonInteractive: true, password: "existing-admin-secret" });

process.env.INITIAL_PASSWORD = "CHANGEME";
const exitCode = await runSetupCommand({ nonInteractive: true });

assert.equal(exitCode, 0);

const db = new Database(path.join(dataDir, "storage.sqlite"));
const passwordRow = db
.prepare("SELECT value FROM key_value WHERE namespace = 'settings' AND key = 'password'")
.get() as { value: string };
db.close();

const storedHash = JSON.parse(passwordRow.value) as string;
assert.equal(await bcrypt.compare("existing-admin-secret", storedHash), true);
assert.equal(await bcrypt.compare("CHANGEME", storedHash), false);
});
if (ORIGINAL_INITIAL_PASSWORD === undefined) {
delete process.env.INITIAL_PASSWORD;
} else {
process.env.INITIAL_PASSWORD = ORIGINAL_INITIAL_PASSWORD;
}
});
Loading