Repository navigation
Conversation
…itly overridden (diegosouzapw#11494) - Prevents CLI setup from silently overwriting an existing admin password with INITIAL_PASSWORD fallback - Forces requireLogin: true when preserving an existing password to prevent partial/corrupted setup states - Preserves password when no --password flag is provided Signed-off-by: Minxi Hou <[EMAIL_REDACTED]>
HouMinXi
force-pushed
the
fix/11494-cli-setup-password-reset
branch
from
August 25, 2026 14:30
ff7d2ae to
df4854f
Compare
Owner
|
Thanks for catching this — closing in favor of #11522, which already landed the same fix and merged earlier today: No distinct value remains to carry forward — same root cause, same fix shape. Appreciate the independent catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11494: Running
omniroute setup(e.g.--add-provider) on an existing installation silently reset the admin password toCHANGEMEvia the fallbackINITIAL_PASSWORDin.env.Changes
bin/cli/commands/setup.mjs::setupPassword, checks whethergetSettings(db).passwordalready exists.--password, setup preserves the existing password and printsUsing existing admin passwordwithout re-hashing or overwriting.--passwordis explicitly provided, it updates as expected.Test Plan
tests/unit/cli-setup-password-preservation.test.ts(2 integration-style CLI tests with real SQLite instances).npm run typecheck:coreclean.Closes #11494