Skip to content

fix(dashboard): expose custom mode-pack option - #11407

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.50from
jacobsparts:fix/custom-mode-pack
Aug 24, 2026
Merged

fix(dashboard): expose custom mode-pack option#11407
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.50from
jacobsparts:fix/custom-mode-pack

Conversation

@jacobsparts

@jacobsparts jacobsparts commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Problem

Operators could tune custom slider weights, but the mode-pack selector exposed only named presets. Choosing a preset overwrote those weights and there was no visible way to select the runtime's existing custom mode.

Summary

  • Expose the existing custom sentinel in the shared mode-pack selector so operators can retain slider weights.
  • Both UI flows consume the shared list, and runtime already leaves weights unchanged when custom resolves no preset.

Related Issues

Validation

  • Change type: UI
  • Focused regression test passed
  • Focused category gates from the Contribution Golden Path
  • npm run lint
  • Reconciled with the current active release base; focused checks rerun afterward
  • Production-code changes include a new or updated automated test in this PR

This is a draft. Final category-gate and lint results will be recorded before review.

Tests Added Or Updated

  • tests/unit/autocombo-unification.test.ts

Coverage Notes

  • The updated regression verifies the option, normalization, and absence of a named custom preset.
  • No known touched-file coverage decrease.

Reviewer Notes

  • Absent mode packs still default to ship-fast; no migration is included.

@jacobsparts
fix(dashboard): expose custom mode-pack option
719b236 
Named mode packs override slider weights, but both combo editors offered only presets. Add the shared custom sentinel so users can persist slider intent; runtime already retains configured weights when no preset resolves.
@jacobsparts
jacobsparts force-pushed the fix/custom-mode-pack branch from c1f8a6b to 719b236 Compare August 24, 2026 16:37
@diegosouzapw
diegosouzapw marked this pull request as ready for review August 24, 2026 17:15
@diegosouzapw
diegosouzapw self-requested a review as a code owner August 24, 2026 17:15
diegosouzapw pushed a commit that referenced this pull request Aug 24, 2026
@jacobsparts
fix(sse): preserve auto-selected first target (#11399)
b1fdfd5 
Validado em lote combinado (batch-0824f, junto de #11400/#11402/#11407) contra o tip de release/v3.8.50: typecheck:core limpo, file-size/changelog/complexity/cognitive-complexity OK (abaixo do baseline), 56/56 testes focados passando incluindo os deste PR (tests/unit/8370-priority-affinity-reorder.test.ts).

Aditivo e coerente: protege a ordem já decidida pelo `auto` contra reordenação pelo pós-processamento de prompt-cache-affinity — mesma linha do #11400. Obrigado pela contribuição!
diegosouzapw pushed a commit that referenced this pull request Aug 24, 2026
@jacobsparts
fix(sse): preserve auto scoring order (#11400)
ddee064 
Validado em lote combinado (batch-0824f, junto de #11399/#11402/#11407) contra o tip de release/v3.8.50: typecheck:core limpo, file-size/changelog/complexity/cognitive-complexity OK, 56/56 testes focados passando incluindo os deste PR (tests/unit/combo-task-aware.test.ts).

Remove `auto` da lista de estratégias task-routing genéricas — coerente com o #11399, que também protege a ordem já computada pelo `auto` contra reordenação por outro pós-processamento. Obrigado pela contribuição!
diegosouzapw pushed a commit that referenced this pull request Aug 24, 2026
@jacobsparts
fix(dashboard): normalize explicit auto weights (#11402)
7b36e45 
Validado em lote combinado (batch-0824f, junto de #11399/#11400/#11407) contra o tip de release/v3.8.50: typecheck:core limpo, file-size/changelog/complexity/cognitive-complexity OK, 56/56 testes focados passando incluindo os deste PR (tests/unit/combo-scoring-inspector.test.ts).

Baixo risco: normaliza pesos parciais/não-unitários no inspector de diagnóstico (`comboScoringInspector.ts`) reutilizando o normalizador já existente do motor real de scoring, mantendo diagnósticos consistentes com o runtime. Obrigado pela contribuição!
@diegosouzapw
diegosouzapw merged commit 56d64e2 into diegosouzapw:release/v3.8.50 Aug 24, 2026
3 checks passed
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
@jacobsparts
fix(sse): preserve auto-selected first target (diegosouzapw#11399)
2038345 
Validado em lote combinado (batch-0824f, junto de diegosouzapw#11400/diegosouzapw#11402/diegosouzapw#11407) contra o tip de release/v3.8.50: typecheck:core limpo, file-size/changelog/complexity/cognitive-complexity OK (abaixo do baseline), 56/56 testes focados passando incluindo os deste PR (tests/unit/8370-priority-affinity-reorder.test.ts).

Aditivo e coerente: protege a ordem já decidida pelo `auto` contra reordenação pelo pós-processamento de prompt-cache-affinity — mesma linha do diegosouzapw#11400. Obrigado pela contribuição!
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
@jacobsparts
fix(sse): preserve auto scoring order (diegosouzapw#11400)
88a936e 
Validado em lote combinado (batch-0824f, junto de diegosouzapw#11399/diegosouzapw#11402/diegosouzapw#11407) contra o tip de release/v3.8.50: typecheck:core limpo, file-size/changelog/complexity/cognitive-complexity OK, 56/56 testes focados passando incluindo os deste PR (tests/unit/combo-task-aware.test.ts).

Remove `auto` da lista de estratégias task-routing genéricas — coerente com o diegosouzapw#11399, que também protege a ordem já computada pelo `auto` contra reordenação por outro pós-processamento. Obrigado pela contribuição!
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
@jacobsparts
fix(dashboard): normalize explicit auto weights (diegosouzapw#11402)
3c1dff2 
Validado em lote combinado (batch-0824f, junto de diegosouzapw#11399/diegosouzapw#11400/diegosouzapw#11407) contra o tip de release/v3.8.50: typecheck:core limpo, file-size/changelog/complexity/cognitive-complexity OK, 56/56 testes focados passando incluindo os deste PR (tests/unit/combo-scoring-inspector.test.ts).

Baixo risco: normaliza pesos parciais/não-unitários no inspector de diagnóstico (`comboScoringInspector.ts`) reutilizando o normalizador já existente do motor real de scoring, mantendo diagnósticos consistentes com o runtime. Obrigado pela contribuição!
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
@jacobsparts
fix(dashboard): expose custom mode-pack option (diegosouzapw#11407)
28e063d 
Validado em lote combinado (batch-0824f, junto de diegosouzapw#11399/diegosouzapw#11400/diegosouzapw#11402) contra o tip de release/v3.8.50: typecheck:core limpo, file-size/changelog/complexity/cognitive-complexity OK, 56/56 testes focados passando incluindo os deste PR (tests/unit/autocombo-unification.test.ts).

Baixo risco: expõe a opção "custom" já suportada em runtime (`getModePack("custom") === undefined`, cai de volta para os pesos explícitos dos sliders) no seletor compartilhado de mode-pack da UI. Obrigado pela contribuição!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegosouzapw diegosouzapw Awaiting requested review from diegosouzapw diegosouzapw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jacobsparts @diegosouzapw