fix(deps): keep unused pnpm peers out of production - #11342
Merged
Merged
Conversation
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
* fix(deps): keep unused pnpm peers out of production * docs(changelog): link dependency policy fix to PR 11342
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@lobehub/uipeer subtree declared by@lobehub/icons.legacy-peer-depsposture.The affected subtree was not present in
package-lock.json, was not imported by OmniRoute, and existed only because pnpm automatically installed an optional UI peer. WithautoInstallPeers: false, a freshly generated temporary pnpm lock contains zero resolutions for@giscus/react,@pierre/diffs,@pierre/theming,@splinetool/runtime,chroma-js, orelkjs.Related Issues
Validation
Choose the change type and focused loop from the
Contribution Golden Path. The full unit suite,
Vitest, the 60% coverage gate, and the production build all run in CI on this PR (#8329):
npm run lint— focused ESLint passed; full lint remains delegated to CIExact post-rebase evidence against
release/v3.8.50at9b14896a6cb61f2eda1c091a219a8558d10e5fb4:node --import tsx/esm --test tests/unit/build/check-licenses.test.ts— 37/37 PASSnpm run check:licenses— PASS, 951 production packages, 0 policy violationsCHANGELOG_BASE_REF=refs/remotes/origin/release/v3.8.50 npm run check:changelog-integrity— PASSgit diff --check— PASSTests Added Or Updated
tests/unit/build/check-licenses.test.tspnpm-workspace.yamldisables peer auto-installation;Coverage Notes
src/,open-sse/,electron/, orbin/production code changed.Reviewer Notes
pnpm-lock.yamlis tracked by this PR. A temporary lock was generated only as validation and then deleted.caniuse-lite, andtls-client-nodeare unchanged.