Repository navigation
fix(opencode-plugin): track active release branch in CI + align combo-id fixture - #11301
Merged
diegosouzapw merged 1 commit intoAug 24, 2026
Merged
Conversation
…-id fixture The opencode-plugin CI workflow trigger was pinned to release/v3.8.2 since its creation, so it stopped firing once the active release line moved on — the workflow never ran mid-cycle. Switch push/pull_request branch filters to release/** so it tracks whatever release branch is active. Also align the provider.test.ts fixture expectations with the combo-id contract from #10345/#10821: mapRawModelToModelV2 leaves bare combo ids (owned_by: "combo") unprefixed so OpenCode's `-m <plugin>/<combo>` lookup resolves them directly. The two assertions still expected the old provider-prefixed form. Closes #11291 Closes #11292
This was referenced Aug 24, 2026
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…-id fixture (diegosouzapw#11301) Validated on a 4-PR combined board: @omniroute/opencode-plugin provider.test.ts 13/13, full plugin suite 343/343, YAML validated, typecheck:core clean, gates within baseline. CI branch trigger was pinned to release/v3.8.2 since creation (never fired mid-cycle) — now tracks [main, release/**] matching every other workflow's pattern; combo-id fixture aligned to the real diegosouzapw#10821 unprefixed-lookup contract (RED 11/13 → GREEN 13/13).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opencode-plugin-ci.ymlpush/pull_request branch triggers were pinned torelease/v3.8.2since the workflow's creation. The active release line has since moved on (release/v3.8.50), so the workflow never fired mid-cycle. Switched bothbranches:filters to[main, "release/**"], matching the pattern already used bysemgrep.yml,quality.yml,nightly-release-green.yml, anddast-smoke.yml. Thepaths:filter scoping to@omniroute/opencode-plugin/**was already correct and is unchanged.tests/provider.test.tshad two stale assertions expecting the combo idclaude-primary(fixtureowned_by: "combo") to come back key-prefixed asomniroute/claude-primary. Since fix(opencode-plugin): keep bare combo ids unprefixed #10821 (mapRawModelToModelV2,src/index.ts), bare combo ids are left unprefixed so OpenCode's-m <plugin>/<combo>lookup resolves the combo id directly (per fix(backend): publish bare combo IDs in the dynamic OpenCode catalog #10345). Updated the assertions toout["claude-primary"]/claude.id === "claude-primary"and refreshed the stale comment to reference the real contract. Thegemini-3-flash(owned_by: "google") assertions were untouched.Test plan
node --import tsx/esm --test tests/provider.test.ts— RED before fix: 11/13 pass, 2 failures at lines 107 and 163 (exactly the stale assertions). GREEN after fix: 13/13.npm run build && npm test(full@omniroute/opencode-pluginsuite) — 343/343 pass.opencode-plugin-ci.ymlvalidated withpython3 -c "import yaml; yaml.safe_load(open(...))".release/v3.8.50); the branch-filter change follows the exact pattern already proven working in the other workflows listed above.