chore(repo): untrack two planning artifacts that rode into main via #11088 - #11272
Closed
yourspraveen wants to merge 1 commit into
Closed
yourspraveen wants to merge 1 commit into
yourspraveen wants to merge 1 commit into
Conversation
check:tracked-artifacts is red on main: two docs/superpowers/* files are tracked, which the gate forbids (and .gitignore:169 already covers — the ignore never applied because they were tracked before it mattered). They came from diegosouzapw#11213 on release/v3.8.50, were removed there by 855243a, and reached main only because diegosouzapw#11088 was cut from the release line while targeting main, so its squash carried the whole delta including these two. Removing them here mirrors what the release branch already did. Gate green after removal; the CLAUDE.md rule they violate points planning artifacts at _tasks/, not docs/.
Owner
|
Closing as already-covered: the two docs/superpowers planning files were untracked on release/v3.8.50 by 855243a (fix(dashboard) follow-up to #11228), and they ride to main with the v3.8.50 release squash — at which point main matches your PR exactly. Merging this into main separately would just duplicate the deletion. Thank you @yourspraveen for the clean hygiene catch and for deliberately leaving them out of the #11271 port as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes two tracked planning artifacts from
main:Why —
mainis currently red oncheck:tracked-artifactsNot cosmetic. The gate that runs on pre-commit and in CI fails on the current
maintip (65e81158a):After this change:
[tracked-artifacts] OK — no forbidden artifacts tracked by git.docs/superpowers/is already in.gitignore(line 169) — the ignore simply never applied, because the files were tracked before it could matter.tests/unit/build/check-tracked-artifacts.test.ts:111asserts this exact prefix is flagged, so the gate is behaving correctly; the tree is what is wrong.How they got there — my PR, my cleanup
They came from #11213 on
release/v3.8.50, and855243ab1already removed them from that branch. They reachedmainonly through my #11088: the branch was cut from the release line but targetedmain, so the squash carried the full release delta — 5,094 files — including these two. Everything else in that delta was already on the release branch and is correct onmain; these two were the exception, because the release branch had since deleted them.This just mirrors on
mainwhat855243ab1did on the release branch. PerCLAUDE.md, planning artifacts belong in_tasks/superpowers/, notdocs/.Verification
npm run check:tracked-artifacts— FAIL before, OK aftergrep -rn "docs/superpowers"returns only theCLAUDE.mdrule text, aquantumPatterns.tscomment pointing at a different (already-untracked) design doc, and the two gate tests