refactor(dashboard): mirror check button disable state in AddApiKeyModal Enter handler (#10995) - #11156
Merged
diegosouzapw merged 1 commit intoAug 22, 2026
Conversation
rqzbeh
force-pushed
the
refactor/add-api-key-modal-enter-polish
branch
4 times, most recently
from
August 22, 2026 22:24
8a64cb7 to
dff4865
Compare
diegosouzapw
force-pushed
the
refactor/add-api-key-modal-enter-polish
branch
from
August 22, 2026 23:13
dff4865 to
fd96e3f
Compare
diegosouzapw
merged commit Aug 22, 2026
d3ac1a6
into
diegosouzapw:release/v3.8.50
0 of 3 checks passed
diegosouzapw
pushed a commit
that referenced
this pull request
Aug 23, 2026
Merged after conflict resolution (validated on the combined batch board + this branch): stale drift files (package.json/package-lock/.gitignore) kept at tip; the two modals merged additively — AWS SigV4 fields coexist with the chatgpt-web-codex tunnel fields and the #11156 Enter-handler mirror (vitest 2/2 re-run). file-size gate green with the dated AddApiKeyModal 1173 entry (owner-authorized). aws-polly modal + provider-validation-specialty 127/127. Base was mistakenly main; retargeted to release/v3.8.50. Credentials stay in the protected field; nothing logged. Thank you @rafacpti23!
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…dal Enter handler (diegosouzapw#10995) (diegosouzapw#11156) Cherry-picked onto the current tip (authorship preserved), generated-count noise stripped. Pre-merge: file-size baseline rebaselined 1080→1082 with dated annotation (the +2 lines are the Enter-handler isCheckDisabled mirror — owner-requested diegosouzapw#11056 polish; rest is Prettier reflow). Gate green; vitest add-api-key-modal-enter-key 2/2 (jsdom render test). Thank you @rqzbeh!
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
Merged after conflict resolution (validated on the combined batch board + this branch): stale drift files (package.json/package-lock/.gitignore) kept at tip; the two modals merged additively — AWS SigV4 fields coexist with the chatgpt-web-codex tunnel fields and the diegosouzapw#11156 Enter-handler mirror (vitest 2/2 re-run). file-size gate green with the dated AddApiKeyModal 1173 entry (owner-authorized). aws-polly modal + provider-validation-specialty 127/127. Base was mistakenly main; retargeted to release/v3.8.50. Credentials stay in the protected field; nothing logged. Thank you @rafacpti23!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the two post-merge polish suggestions from #11056 for
AddApiKeyModal:Mirrored Check Disabling Condition:
Updated the
onKeyDownEnter key handler inAddApiKeyModal.tsxto reuseisCheckDisabled((!isCompatible && !apiKeyOptional && !formData.apiKey) || (isGooglePse && !formData.cx.trim()) || validating || saving). This prevents dispatching unnecessary validation requests when the field is empty or Google PSEcxis missing.React Render Test:
Converted
tests/unit/ui/add-api-key-modal-enter-key.test.tsxto a React render test simulatingkeydownEnter events with@vitest-environment jsdom.Code Formatting:
Formatted test code using Prettier.
Verification
npx vitest run tests/unit/ui/add-api-key-modal*.test.tsx(10/10 tests passed)npm run typecheck:core(0 errors)npx eslint(0 issues)