fix(release): drain v3.8.50 base-reds — getTokenLimit contract, Vietnamese i18n parity, eslint gate

[diegosouzapw]

Refs #9985

Drains the 3 base-reds that reproduce on the pure tip of release/v3.8.50 (discriminated: each failure reproduced with zero local diff before any change).

1) getTokenLimit non-hyperagent — test aligned to the new contract

Symptom: tests/unit/context-manager.test.ts "does not force 1M onto non-hyperagent providers serving the same model ids" expected getTokenLimit("windsurf", "claude-opus-4.7-max") → 200000, code returns 1000000.

Discrimination: reproduces on the pure tip with zero diff. git log -p origin/release/v3.8.50 on source vs test: the test file is untouched since d54a659, while TWO intentional merges changed the resolution chain underneath it:

• acc066d ([v3.8.50] feat(devin-desktop): replace public Windsurf provider #8228) — retired windsurf as a built-in provider (replaced by devin-desktop), deleting the explicit per-model contextLength: 200000 pin the assert relied on.
• 00dfdad (fix(combo): resolve effort variants via base model capabilities #11034) — effort-suffix variant resolution in getResolvedModelCapabilities: with no direct source left, stripKnownEffortSuffix maps claude-opus-4.7-max → base claude-opus-4.7 → canonical claude-opus-4-7, whose real catalog window is 1M (cursor catalogs the same id as "Opus 4.7 1M Max").

Decision: align the test (code is right, assert was stale). The 1M now comes from the shared model catalog via legitimate base-model resolution — NOT the forbidden hyperagent-default leak the test guards. bluesminds/claude-opus-4-5 → 200000 kept unchanged and still guards the original #8496 intent. Proof: node --import tsx/esm --test tests/unit/context-manager.test.ts → 29/29.

2) Vietnamese i18n parity — translations added

Symptom: tests/unit/i18n-vi-completeness.test.ts — 4 failures (key parity, missing markers/empty fallbacks, ICU placeholders, ICU parse).

Root cause: 6cd4d38 (#11069) added 14 providers.harImport* keys to en.json with no vi translations; agentSkills.catalog.omni-webhooks.description carried a literal __MISSING__: fallback.

Fix: 14 Vietnamese translations added to src/i18n/messages/vi.json (mirroring en.json placement, {minutes} ICU placeholder preserved verbatim, no __MISSING__ markers) + real translation for the omni-webhooks description (technical event names kept as-is). Proof: same test file → 5/5. User-visible change → changelog fragment changelog.d/fixes/release-v3850-basereds-tests-i18n.md.

3) ESLint gate — 4 new unsuppressed no-explicit-any errors fixed

Symptom: env -u OMNIROUTE_API_KEY npm run lint:json -- --max-warnings 0 → exit 1 on the pure tip (CI run 32403951361, job "No new ESLint warnings").

Discrimination: NOT orphaned suppressions (JSON inventory: 0 warnings, no stale entries). The full inventory shows exactly 4 errors — @typescript-eslint/no-explicit-any in tests/unit/capture-critical-db-state.test.ts:11-14, introduced by 0ff0490 (#10906) which rewrote the suite keeping any holders for dynamically imported core.ts exports.

Fix (trivial/safe, purely typal): type CoreModule = typeof import("../../src/lib/db/core.ts") + typed holders — the runtime dynamic-import timing (DATA_DIR must be set before core.ts loads) is untouched. No suppression changes needed. Proof: file lints clean; full npm run lint:json -- --max-warnings 0 re-run → exit 0.

Gates

• tests/unit/context-manager.test.ts 29/29, tests/unit/i18n-vi-completeness.test.ts 5/5, tests/unit/capture-critical-db-state.test.ts 7/7 (41/41 combined)
• typecheck:core clean
• check:file-size OK
• check:changelog-integrity OK (no base bullets lost)
• npm run lint:json -- --max-warnings 0 exit 0