fix(webhooks): followup ghost-event dispatcher + vi i18n (#11050) - #11130
Merged
diegosouzapw merged 1 commit intoAug 22, 2026
Conversation
…souzapw#11050) diegosouzapw#11050 removed provider.error/recovered/combo.switched from EVENT_DESCRIPTIONS but the dispatcher tests still iterated/called them, throwing TypeError at runtime (EVENT_DESCRIPTIONS[event] undefined), and vi.json carried __MISSING__ which i18n-vi-completeness bans for vi only. - Drop ghost events from the 3 dispatcher test catalogs + the standalone discord:36 and slack:41 calls; iterate WEBHOOK_EVENT_VALUES instead. - Translate vi.json omni-webhooks.description (41 other locales keep the marker by design — sync-ui-keys convention). - Add a runtime smoke test asserting builders accept all WEBHOOK_EVENT_VALUES; keep the negative ghost-string assertions in webhooks-ghost-events.test.ts. Why: owner flagged 2 blockers on the already-merged diegosouzapw#11050; this followup closes both without touching eventDescriptions.ts (already correct). Decision: runtime smoke test (not static source-scan gate) as the AXE6 anchor; retarget ghost calls to request.failed with {provider} shape. Co-Authored-By: opencode <noreply@opencode.ai>
maxmad64bis
force-pushed
the
fix/11050-webhooks-ghost-events-followup
branch
from
August 22, 2026 12:12
f0894f3 to
1a8002a
Compare
5 tasks done
diegosouzapw
merged commit Aug 22, 2026
b44f22a
into
diegosouzapw:release/v3.8.50
9 of 16 checks passed
diegosouzapw
pushed a commit
that referenced
this pull request
Aug 23, 2026
…0964) Merged after conflict triage: the six base-red repair files (vi.json, opencode.ts JSDoc, context-manager test, the three webhook dispatcher tests, the uncloseai orphan-test rename) were already drained on the tip by today's #11130/#11157/#11160/#11113 — those hunks resolved to the tip shape. What lands is the production-fix set: GLM transport-aware Anthropic headers, Claude Code-compatible model-listing rejection, combo live-test single-probe, zero-cost Auto-Combo interval normalization, recovery-clearing union handling, LLMLingua real-path compare, macOS netstat PID discovery, AI Horde R2 strict public-host validation. Sweep of every touched test file: 243/243 green; typecheck + file-size clean. (guide-settings-route's 4 reds reproduce on the pure tip — pre-existing drift from #11079, not from here.) Thank you @backryun!
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…souzapw#11050) (diegosouzapw#11130) Validated on the combined batch board over release/v3.8.50 tip 0f43f0f: static gates clean, typecheck:core clean, focused tests green. Closes the two diegosouzapw#11050 blockers: dispatcher tests now derive from WEBHOOK_EVENT_VALUES (no more TypeError on removed events) and vi.json carries a real translation. Thank you @maxmad64bis!
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…egosouzapw#10964) Merged after conflict triage: the six base-red repair files (vi.json, opencode.ts JSDoc, context-manager test, the three webhook dispatcher tests, the uncloseai orphan-test rename) were already drained on the tip by today's diegosouzapw#11130/diegosouzapw#11157/diegosouzapw#11160/diegosouzapw#11113 — those hunks resolved to the tip shape. What lands is the production-fix set: GLM transport-aware Anthropic headers, Claude Code-compatible model-listing rejection, combo live-test single-probe, zero-cost Auto-Combo interval normalization, recovery-clearing union handling, LLMLingua real-path compare, macOS netstat PID discovery, AI Horde R2 strict public-host validation. Sweep of every touched test file: 243/243 green; typecheck + file-size clean. (guide-settings-route's 4 reds reproduce on the pure tip — pre-existing drift from diegosouzapw#11079, not from here.) Thank you @backryun!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the already-merged #11050: closes the two blockers the owner flagged.
webhook-discord/slack/telegram-dispatcher.test.ts) still iterated/called the removed eventsprovider.error/provider.recovered/combo.switched, throwingTypeError: Cannot read properties of undefinedat runtime (EVENT_DESCRIPTIONS[event]). Replaced the hand-copied catalogs withWEBHOOK_EVENT_VALUESand retargeted the standalonediscord:36/slack:41calls torequest.failedwith{ provider }shape.vi.jsoncarried__MISSING__:onomni-webhooks.description, whichtests/unit/i18n-vi-completeness.test.tsbans forvionly. Translated it to Vietnamese. The other 41 locales keep the marker by design (thesync-ui-keys.mjsconvention;i18n-ui-value-drifttreats__MISSING__:as the legitimate staleness signal).WEBHOOK_EVENT_VALUES. The negative ghost-string assertions inwebhooks-ghost-events.test.tsare kept (they prove the removal).Related Issues
Validation
Change type: i18n / other (test-only + one i18n value)
webhook-discord/slack/telegram-dispatcher.test.ts,i18n-vi-completeness.test.ts,i18n-ui-value-drift.test.ts,webhooks-ghost-events.test.tsall passnpm run lint(pre-commit hooks ran on commit)upstream/release/v3.8.50vi.json) includes an automated test in this PR (i18n-vi-compat/completeness)Tests Added Or Updated
tests/unit/webhooks-ghost-events.test.ts— new positive smoke test overWEBHOOK_EVENT_VALUEStests/unit/webhook-discord-dispatcher.test.ts,webhook-slack-dispatcher.test.ts,webhook-telegram-dispatcher.test.ts— catalogs now derive fromWEBHOOK_EVENT_VALUES; slack test name updatedCoverage Notes
src//open-sse//electron//bin/production logic changed (only a test file and one i18n value). Thevi.jsonvalue change is covered by the existingi18n-vi-completenessgate.Reviewer Notes
eventDescriptions.tsis intentionally NOT touched (it was already correct in fix(webhooks): remove 3 declared-but-never-emitted events #11050).