Repository navigation
fix(release): drain v3.8.50 base-reds — build-breaking import, stale provider docs, orphaned suppressions - #11037
Closed
diegosouzapw wants to merge 2 commits into
Closed
diegosouzapw wants to merge 2 commits into
diegosouzapw wants to merge 2 commits into
Conversation
…em metadata `assertValidEngine()` valida id, apply, compress, getConfigSchema e validateConfig — não exige `metadata`. Uma engine registrada sem esse campo é, portanto, um registro legal. Mas `canRunAtCompressionStage` lia `engine.metadata.executionStages` sem guarda, então essa engine legal derrubava o pipeline inteiro com `TypeError: Cannot read properties of undefined` em vez de falhar aberto, que é o contrato da compressão. Metadata ausente é o mesmo caso de "não declarou executionStages" e passa a cair no mesmo fallback documentado: só pre-translation. Isso destravava também `tests/unit/compression/pipeline-circuit-breaker.test.ts`, que registra uma engine de teste sem metadata e vinha 8/9 na base — agora 9/9. O teste novo torna o contrato explícito, em vez de deixá-lo dependendo de uma reprodução incidental noutro arquivo.
…e-v3.8.50-basereds
Owner
Author
|
Closing — this PR was accidentally created pointing at another session's in-flight branch of the same name (its head carries a compression fix, not the changes described here). The described base-red fixes are being reopened from a distinctly named branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #9985
Drains the three classes of base-red currently failing every PR against release/v3.8.50:
src/app/api/usage/utilization/route.tsimportedgetConnectionfrom@/lib/db/connections, a module that does not exist (introduced by the fix(dashboard): show account email/name in Utilization Account Split cards #10939 merge, c0fd109; typecheck:core does not cover app routes, so only next build catches it). Fixed togetProviderConnectionByIdfrom@/lib/db/providers(awaited). Regression test:tests/unit/utilization-route-import-10939.test.ts(module import is the repro — ERR_MODULE_NOT_FOUND on the base, resolves here).docs/reference/PROVIDER_REFERENCE.mdregenerated vianpm run gen:provider-reference(346 → 347) and the four README diagram SVGs updated to the real count.npm run lint:json -- --max-warnings 0 --prune-suppressionson the clean base tip removed suppressions orphaned by earlier merges (the gate fails with "suppressions left that do not occur anymore" for every PR); lint exits 0 after the prune.