Repository navigation
fix(dashboard): List Models card must not hardcode models={null} (#10553) - #10753
Merged
Merged
Conversation
giauphan
pushed a commit
to giauphan/OmniRoute
that referenced
this pull request
Aug 20, 2026
…gosouzapw#10553) (diegosouzapw#10753) Co-authored-by: Markus Hartung <mail@hartmark.se>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…gosouzapw#10553) (diegosouzapw#10753) Co-authored-by: Markus Hartung <mail@hartmark.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10553
Root cause: the "List Models" EndpointCard (path
/v1/models) on the Endpoints dashboard tab was hardcoded withmodels={null}, so EndpointCard's render logic (models === null ? "—" : ...) permanently took the "—" branch. Every sibling card that maps to an actual model-list endpoint is fed a real array +modelsLoading; fixed List Models to usemodels={allModels}+modelsLoading={modelsLoading}, matching the existing pattern.Regression test: tests/unit/dashboard/endpoint-list-models-card-10553.test.ts.
npx eslinton the touched file reports 3 pre-existing errors (temporal-dead-zone lint findings at lines 310/315/316, unrelated to this change) — confirmed present onorigin/release/v3.8.50tip before this PR (base-red drift, not introduced here).