Repository navigation
fix(proxy): keep password-only proxy credentials (#10720) - #10752
Merged
Merged
Conversation
giauphan
pushed a commit
to giauphan/OmniRoute
that referenced
this pull request
Aug 20, 2026
…diegosouzapw#10752) Co-authored-by: Markus Hartung <mail@hartmark.se>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…diegosouzapw#10752) Co-authored-by: Markus Hartung <mail@hartmark.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10720
Root cause:
proxyConfigToUrl()andbuildProxyUrlString()inopen-sse/utils/proxyDispatcher.tsonly built the auth segment whenusernamewas truthy, silently dropping a password-only proxy credential (RFC-3986 allowsscheme://:password@host:port). Both the object-config builder and the URL-rebuild helper used duringnormalizeProxyUrl()had the same gap. Fixed both call sites to include the auth segment whenever either username or password is present.Regression test: tests/unit/probe-10720-proxy-password-only-auth.test.ts (3 assertions: password-only, username+password, neither).