Repository navigation
fix(sensenova): clamp unsupported max reasoning effort to xhigh - #10733
Merged
diegosouzapw merged 1 commit intoAug 20, 2026
Merged
Conversation
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
Merged via merge-train (release/v3.8.50, batch1 2026-08-20) — static gates (typecheck/file-size/complexity/cognitive/changelog) green on the combined tree; test:unit reds observed in the boarded run were verified pre-existing on the pure release tip (unrelated flake), not caused by this PR. Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasoning_effort: "max"toxhighfor SenseNova'sdeepseek-v4-flash, whose upstream contract explicitly accepts up toxhighbut rejectsmax.maxpassthrough for models without explicit per-model effort metadata and avoid cross-provider capability lookup for same-ID models.Related Issues
Validation
Choose the change type and focused loop from the
Contribution Golden Path. The full unit suite,
Vitest, the 60% coverage gate, and the production build all run in CI on this PR (#8329):
node --import tsx/esm --test tests/unit/base-reasoning-effort-split.test.ts tests/unit/sensenova-reasoning-effort.test.ts tests/unit/opencode-zen-reasoning-effort.test.tsmaxwas normalized toxhigh;sensenova/deepseek-v4-flashreturned HTTP 200 with a non-empty reply.npm run lintTests Added Or Updated
tests/unit/sensenova-reasoning-effort.test.ts.Coverage Notes
tests/unit/sensenova-reasoning-effort.test.tscovers the explicit SenseNovamaxtoxhighnormalization and verifies that a SenseNova model without explicit effort metadata continues to preservemax.tests/unit/opencode-zen-reasoning-effort.test.tsconfirms same-ID OpenCode models retain their existingmaxpassthrough behavior.tests/unit/base-reasoning-effort-split.test.tsconfirms both supported import paths resolve to the same sanitizer.Reviewer Notes
max; models with absent metadata keep the existing passthrough behavior.