Skip to content

pUpdate python_requests.py - #10731

Merged
diegosouzapw merged 2 commits into
diegosouzapw:release/v3.8.50from
pandaaaa1990:patch-1
Aug 20, 2026
Merged

diegosouzapw merged 2 commits into
diegosouzapw:release/v3.8.50from
pandaaaa1990:patch-1

Conversation

@pandaaaa1990

@pandaaaa1990 pandaaaa1990 commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Describe the user-facing or operational change.

Related Issues

  • Closes #
  • Related to #

Validation

Choose the change type and focused loop from the
Contribution Golden Path. The full unit suite,
Vitest, the 60% coverage gate, and the production build all run in CI on this PR (#8329):

  • Change type: provider / routing / UI / i18n / CLI / DB / build-deploy / other
  • Focused tests and category gates from the golden path
  • npm run lint
  • Reconciled with the current active release base; focused checks rerun afterward
  • Production-code changes include a new or updated automated test in this PR
  • SonarQube is temporarily opt-in while the private project has no quota; it is not a PR gate.

Tests Added Or Updated

  • List every changed or added automated test file.
  • If no production code changed, state that here.

Coverage Notes

  • If this PR changes src/, open-sse/, electron/, or bin/, explain which tests cover the change.
  • If coverage moved down in any touched file, explain why and what follow-up task will recover it.

Reviewer Notes

  • Call out any risky areas, migrations, feature flags, or manual validation that reviewers should know about.

@diegosouzapw

Copy link
Copy Markdown
Owner

Thanks for the idea — showing that auto works with zero credentials out of the box is a good addition! But the added block is raw shell (curl ...) appended directly to a .py file, which breaks Python syntax (python3 -m py_compile examples/quickstart/python_requests.py fails with a SyntaxError on the curl line).

Could you wrap it as a comment, e.g.:

# Fresh install, zero credentials — `auto` already works:
# curl http://localhost:20128/v1/chat/completions \
#   -H "Content-Type: application/json" \
#   -d '{"model":"auto","messages":[{"role":"user","content":"Hello!"}]}'

Happy to merge once that's fixed.

…syntax

Co-authored-by: pandaaaa1990 <amirypo73@gmail.com>
@diegosouzapw
diegosouzapw merged commit 48f3428 into diegosouzapw:release/v3.8.50 Aug 20, 2026
3 checks passed
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
Merged via merge-train (release/v3.8.50, batch1 2026-08-20) — static gates (typecheck/file-size/complexity/cognitive/changelog) green on the combined tree; test:unit reds observed in the boarded run were verified pre-existing on the pure release tip (unrelated flake), not caused by this PR. Thanks for the contribution!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants