Repository navigation
fix(cline): label OmniRoute health checks as internal - #10706
Merged
diegosouzapw merged 1 commit intoAug 20, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
arafatkatze
marked this pull request as ready for review
August 19, 2026 18:31
Contributor
Author
|
Oi @diegosouzapw! Aqui é o Ara, do time da @cline. Quando tiver um tempinho, agradeceria muito uma revisão rápida deste PR — a mudança é pequena e fácil de testar. Obrigado! |
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
Merged via merge-train (release/v3.8.50, batch1 2026-08-20) — static gates (typecheck/file-size/complexity/cognitive/changelog) green on the combined tree; test:unit reds observed in the boarded run were verified pre-existing on the pure release tip (unrelated flake), not caused by this PR. Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
As verificações de integridade de modelos e combos do OmniRoute já se identificam com:
X-Internal-Test: combo-health-checkQuando uma dessas verificações é encaminhada pelo Cline, o construtor de headers do Cline atualmente a identifica com o mesmo valor
X-CLIENT-TYPE: omnirouteusado pelo tráfego normal de usuários. Por isso, a telemetria downstream não consegue distinguir as verificações internas do OmniRoute das requisições de usuários.Alteração
combo-health-checkparaX-CLIENT-TYPE: omniroute-internal-health-checkX-CLIENT-TYPE: omnirouteEsta alteração não adiciona nenhum header ou campo no banco de dados e não modifica o corpo das requisições, o roteamento, a autenticação, o faturamento ou os IDs de tarefa.
Teste
O teste de regressão falhava antes da implementação (
omnirouteem vez deomniroute-internal-health-check) e passou depois dela (12/12).Também passaram:
base-redherdado: #9985. A suíte ampla de testes unitários não é usada como evidência neste PR; caminhos não relacionados da branch base falharam localmente, enquanto o teste de regressão focado e as verificações principais acima estão passando.