Repository navigation
fix(tests): drain three base-reds left by the SSE-comment default and a locale gap - #10704
Merged
diegosouzapw merged 2 commits intoAug 19, 2026
Merged
Conversation
… a locale gap All three reproduce on a pristine tip; none is caused by the branch that found them. 1. i18n vi — six keys landed in en.json without a Vietnamese counterpart (settings.reasoningTokenBuffer*, settings.zeroLatencyOptimizations*, settings.compressionOutputStyle.i-have-adhd.*). The vi locale is held to strict parity, so the whole i18n-vi suite went red. Translated; no existing key reordered. 2. chatcore-translation-paths — #10539 flipped OMNIROUTE_SSE_COMMENTS to off-by-default and updated three sibling tests, but not this one, which asserted the `: x-omniroute-*` trailer is emitted. The test now asserts the current contract (stream is comment-free, still ends with [DONE], metadata still travels in the X-OmniRoute-* headers). The opt-in half stays covered by sse-comments-optout-9305.test.ts, which drives the env var through all three states. Enabling the flag inside this file instead leaks process.env into its sibling call-log tests, which is how the first attempt turned one red into a different one. 3. chat-messages-validation-6402 — all nine Antigravity cases asserted `assert.match(body, /ok/)` against the mocked model output. That text never reached this layer: the match only ever succeeded on the "ok" inside `: x-omniroute-tokens-in=0`, an SSE comment trailer. When the trailers stopped being emitted the coincidence broke, not the behavior — bisected to 6b823aa, whose parent 6d99a46 passes. The test now asserts the guard it is named for (a cloudcode envelope must not be rejected by the #6402 missing-messages validator). Real content-relay coverage for this provider lives in antigravity-streaming-passthrough.test.ts, which passes. Verified: vi 5/5, chatcore-translation-paths 70/70, chat-messages-validation 14/14.
giauphan
pushed a commit
to giauphan/OmniRoute
that referenced
this pull request
Aug 20, 2026
… a locale gap (diegosouzapw#10704) * fix(tests): drain three base-reds left by the SSE-comment default and a locale gap All three reproduce on a pristine tip; none is caused by the branch that found them. 1. i18n vi — six keys landed in en.json without a Vietnamese counterpart (settings.reasoningTokenBuffer*, settings.zeroLatencyOptimizations*, settings.compressionOutputStyle.i-have-adhd.*). The vi locale is held to strict parity, so the whole i18n-vi suite went red. Translated; no existing key reordered. 2. chatcore-translation-paths — diegosouzapw#10539 flipped OMNIROUTE_SSE_COMMENTS to off-by-default and updated three sibling tests, but not this one, which asserted the `: x-omniroute-*` trailer is emitted. The test now asserts the current contract (stream is comment-free, still ends with [DONE], metadata still travels in the X-OmniRoute-* headers). The opt-in half stays covered by sse-comments-optout-9305.test.ts, which drives the env var through all three states. Enabling the flag inside this file instead leaks process.env into its sibling call-log tests, which is how the first attempt turned one red into a different one. 3. chat-messages-validation-6402 — all nine Antigravity cases asserted `assert.match(body, /ok/)` against the mocked model output. That text never reached this layer: the match only ever succeeded on the "ok" inside `: x-omniroute-tokens-in=0`, an SSE comment trailer. When the trailers stopped being emitted the coincidence broke, not the behavior — bisected to 6b823aa, whose parent 6d99a46 passes. The test now asserts the guard it is named for (a cloudcode envelope must not be rejected by the diegosouzapw#6402 missing-messages validator). Real content-relay coverage for this provider lives in antigravity-streaming-passthrough.test.ts, which passes. Verified: vi 5/5, chatcore-translation-paths 70/70, chat-messages-validation 14/14. * chore(changelog): correct the fragment to the real PR number (diegosouzapw#10704) --------- Co-authored-by: Xiangzhe <bakryun0718@proton.me>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
… a locale gap (diegosouzapw#10704) * fix(tests): drain three base-reds left by the SSE-comment default and a locale gap All three reproduce on a pristine tip; none is caused by the branch that found them. 1. i18n vi — six keys landed in en.json without a Vietnamese counterpart (settings.reasoningTokenBuffer*, settings.zeroLatencyOptimizations*, settings.compressionOutputStyle.i-have-adhd.*). The vi locale is held to strict parity, so the whole i18n-vi suite went red. Translated; no existing key reordered. 2. chatcore-translation-paths — diegosouzapw#10539 flipped OMNIROUTE_SSE_COMMENTS to off-by-default and updated three sibling tests, but not this one, which asserted the `: x-omniroute-*` trailer is emitted. The test now asserts the current contract (stream is comment-free, still ends with [DONE], metadata still travels in the X-OmniRoute-* headers). The opt-in half stays covered by sse-comments-optout-9305.test.ts, which drives the env var through all three states. Enabling the flag inside this file instead leaks process.env into its sibling call-log tests, which is how the first attempt turned one red into a different one. 3. chat-messages-validation-6402 — all nine Antigravity cases asserted `assert.match(body, /ok/)` against the mocked model output. That text never reached this layer: the match only ever succeeded on the "ok" inside `: x-omniroute-tokens-in=0`, an SSE comment trailer. When the trailers stopped being emitted the coincidence broke, not the behavior — bisected to d5c4a54, whose parent 639f810 passes. The test now asserts the guard it is named for (a cloudcode envelope must not be rejected by the diegosouzapw#6402 missing-messages validator). Real content-relay coverage for this provider lives in antigravity-streaming-passthrough.test.ts, which passes. Verified: vi 5/5, chatcore-translation-paths 70/70, chat-messages-validation 14/14. * chore(changelog): correct the fragment to the real PR number (diegosouzapw#10704) --------- Co-authored-by: Xiangzhe <bakryun0718@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three reds that reproduce on a pristine checkout of the release tip, with zero local changes.
None is caused by the branch that surfaced them (a docs/Dockerfile PR, #10701, whose full unit
run exposed them).
1.
i18n-vi-completeness— 3 testsSix keys landed in
en.jsonwith no Vietnamese counterpart:settings.reasoningTokenBuffer(Desc),settings.zeroLatencyOptimizations(Desc),settings.compressionOutputStyle.i-have-adhd.{label,description}. Thevilocale is held tostrict parity, so the whole suite went red.
Translated. No existing key reordered — the diff is 9 added lines.
2.
chatcore-translation-paths— "emits final SSE metadata comments before [DONE]"#10539 flipped
OMNIROUTE_SSE_COMMENTSto off-by-default (strict SSE clientsJSON.parseeveryline and crash on
:comments) and updated three sibling tests — but not this one, whichasserted the trailer is emitted.
The test now asserts the current contract: the stream is comment-free, still ends with
[DONE],and the metadata still reaches the client through the
X-OmniRoute-*headers. The opt-in half —trailer present, after the finish chunk, before
[DONE]— stays covered bysse-comments-optout-9305.test.ts, which drives the env var through all three states.3.
chat-messages-validation-6402— all 9 Antigravity casesThese asserted
assert.match(body, /ok/)against the mocked model output. That text neverreached this layer. The match only ever succeeded on the
okinside: x-omniroute-tokens-in=0— an SSE comment trailer. Dumping the body at the last passingcommit shows it contained only trailers, no model text:
When the trailers stopped being emitted, the coincidence broke — not the behavior. Bisected to
6b823aa441(its parent6d99a46d4bpasses); forcingOMNIROUTE_SSE_COMMENTS=onat the tipreproduces the trailers-only body, confirming nothing about content relay changed.
The test now asserts the guard it is named for: a cloudcode envelope (no
messageskey) mustnot be rejected by the #6402 missing-messages validator. Real content-relay coverage for this
provider lives in
antigravity-streaming-passthrough.test.ts(passes, assertschoices[0].message.content === "Hello again").Verification
i18n-vi-completenesschatcore-translation-pathschat-messages-validation-6402Base-reds still open (not in this PR)
Seven more files reproduce on the same tip and need their own triage — some may be product
regressions rather than stale tests:
antigravity-model-aliases(3) ·glm-provider-model-import-route(7) ·executor-qwen-web(1) ·hard-session-lease-bypass-inventory(1) ·i18n-glossary-consistency-check(1, zh-TW) ·instrumentation-warm-catalog-cache(2) ·model-sync-route(2)Plus
npm run lint: 25 errors intests/unit/cli-oauth-commands.test.tsandtests/unit/executor-gitlab.test.ts.Inventory posted to #9985. Note that
Release-Greenreported "Validate active release branch:success" while all of these were red, so that signal is not covering the unit suite the PR
checks run.
Refs #9985, #10539