Skip to content

test(ci): clear release gate regressions - #10693

Closed
cryptiklemur wants to merge 1 commit into
diegosouzapw:release/v3.8.50from
cryptiklemur:fix/release-ci-foundation
Closed

cryptiklemur wants to merge 1 commit into
diegosouzapw:release/v3.8.50from
cryptiklemur:fix/release-ci-foundation

Conversation

@cryptiklemur

@cryptiklemur cryptiklemur commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Two unrelated changes landed on release/v3.8.50 with their regression tests, but left the shared CI branch red:

  • cloudflare-playground began advertising two GLM models while the exact auto/glm provider assertion still expected the old five-provider pool
  • the new CLI OAuth and GitLab fallback tests added three any casts, pushing both files past their frozen ESLint suppression counts and exposing all 25 violations in the lint report

This PR keeps those release-branch repairs out of #10682 through #10686.

what changed

  • include cloudflare-playground in the exact auto/glm provider set
  • replace only the three newly introduced any casts with inferred or structural types
  • leave production code and the existing ESLint suppression baseline unchanged

how to test

npm run test:vitest -- tests/unit/autoCombo/provider-family-combos.test.ts
node --import tsx --test-name-pattern='runOAuthStatus consumes the connections envelope' tests/unit/cli-oauth-commands.test.ts
node --import tsx --test-name-pattern='direct_access returns 401' tests/unit/executor-gitlab.test.ts
npm run lint:json -- --max-warnings 0

The focused tests pass, the full Vitest suite passes 368/368, and the repository-wide no-new-warnings gate passes locally.

current release-branch blockers

The fresh GitHub run confirms this branch's build, Vitest, ESLint, metrics collection, and quality-ratchet phases pass. The workflow is still red on release-wide state outside these three files:

  • the final step of the job named No new ESLint warnings sees 13 open CodeQL alerts against a baseline of 9
  • all four native-test shards fail on unrelated Antigravity, Qwen, i18n, SSE, model-sync, OpenRouter, and usage-history tests
  • Fast Quality Gates reports inherited error-helper, mutation-coverage, dead-code, and open-sse typecheck failures

The same failures are present on the sibling PRs based on this release tip. None of #10693's three touched tests appears in the failed native-test lists.

@diegosouzapw

Copy link
Copy Markdown
Owner

This review could not be executed in the analysis sandbox: the environment did not expose shell or web access, so I was unable to read this PR's diff or run any validation. No verdict is being issued on the changes themselves. Please re-run the analysis for #10693 in an environment where gh pr diff 10693, the probe worktree, and the release-green validation (node scripts/quality/validate-release-green.mjs --quick) can actually execute. No comment/label/edit has been made to this PR.

@cryptiklemur
cryptiklemur force-pushed the fix/release-ci-foundation branch from b81fd18 to b754e44 Compare August 19, 2026 07:38
@mergify

mergify Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ The sha of the head commit of this PR conflicts with #8875. Mergify cannot evaluate rules on this PR. Once #8875 is merged or closed, Mergify will resume processing this PR. ⚠️

@cryptiklemur cryptiklemur reopened this Aug 19, 2026
@cryptiklemur cryptiklemur changed the title fix(ci): restore release quality gates test(auto-combo): include Cloudflare GLM models Aug 19, 2026
@cryptiklemur
cryptiklemur force-pushed the fix/release-ci-foundation branch from 3ad2fbd to cdb11ba Compare August 19, 2026 08:01
@cryptiklemur cryptiklemur changed the title test(auto-combo): include Cloudflare GLM models test(ci): clear release gate regressions Aug 19, 2026
@cryptiklemur

Copy link
Copy Markdown
Contributor Author

Superseded by #10726, which merged these base-red fixes into release/v3.8.50 and includes the broader GitLab response typing cleanup. Closing this one rather than rebasing the older test changes back onto the release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants