Repository navigation
fix(cli): route provider tests through connection API - #10572
Merged
diegosouzapw merged 3 commits intoAug 21, 2026
Merged
diegosouzapw merged 3 commits into
diegosouzapw merged 3 commits into
Conversation
hydraxman
force-pushed
the
fix/cli-provider-test-routes
branch
from
August 17, 2026 22:52
28e4e83 to
3f9fca0
Compare
Owner
|
Looks solid — verified |
…ocal # Conflicts: # bin/cli/commands/test-provider.mjs
…nection test route and valid field
diegosouzapw
merged commit Aug 21, 2026
28788cb
into
diegosouzapw:release/v3.8.50
4 of 7 checks passed
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…0572) Aligns provider-test CLI paths with the server's connection-owned management API: `omniroute test` now resolves a connection and calls `POST /api/providers/{id}/test` instead of the missing `/api/v1/providers/test` route; `--all-providers` carries exact connection ids into both non-interactive and TUI runs. Fixes diegosouzapw#10570. Validated in an isolated worktree boarded onto origin/release/v3.8.50 (0 conflicts, 4 files): - 42/42 focused tests pass (cli-provider-test-routes-10570, cli-providers-command, cli-providers-rotate, cli-route-unavailable-fallback-10081, cli-expanded-commands). - One pre-existing test in cli-expanded-commands.test.ts (not touched by the PR) mocked the old route and the old `success` response field, exposed only after merging with the current release tip — fixed the mock to match the new per-connection route and the `valid` field the real route actually returns, pushed fix-in-place to the PR branch (owner-authorized rule: fix-in-place over reimplementation, credit preserved). - check-file-size, check-changelog-integrity: OK. - typecheck:core: clean. - check-complexity / check-cognitive-complexity: OK, both under baseline. Co-authored-by: hydraxman <hydraxman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligns the provider-test CLI paths with the server's connection-owned management API.
omniroute testnow resolves a configured connection and callsPOST /api/providers/{id}/testinstead of the missing/api/v1/providers/testroute.omniroute test --all-providersaccepts the current{ connections, total }response shape and carries exact connection ids into both non-interactive and TUI runs.omniroute providers test-allkeeps existing local probes, but falls back to the server for custom API-key connections that the local probe table does not support.Related Issue
Fixes #10570
Related to #10564. The separate rotation method mismatch remains owned by #10366.
Type of Change
Testing
node --import tsx/esm --test tests/unit/cli-provider-test-routes-10570.test.ts tests/unit/cli-providers-command.test.ts tests/unit/cli-providers-rotate.test.ts tests/unit/cli-route-unavailable-fallback-10081.test.ts tests/unit/cli-expanded-commands.test.ts— 41 passednpm run test:vitest— 40 files, 362 tests passednpm run lint— passednpm run typecheck:core— passednpm run check:changelog-integrity— passednpm run check:docs-sync— passednpm run check:any-budget:t11— passednpx prettier --check CHANGELOG.md bin/cli/commands/test-provider.mjs bin/cli/tui/ProvidersTestAll.jsx bin/cli/commands/providers.mjs tests/unit/cli-provider-test-routes-10570.test.ts— passednpm run test:unit— did not complete within a 600-second local ceiling; the current release branch has an active base-red report for full-suite hangs/failures in 🔴 Release branch not green: release/v3.8.50 #9985. The focused Node suite and Vitest suite above completed successfully.After publication, four CI jobs failed:
Docs Gates (fast-path),Fast Quality Gates, and unit shards 1/4 and 3/4.Fast Quality Gatesreports the current-basepublic-credsandmutation-test-coveragegates tracked in #9985. I reproduced both failing unit shards locally with the exact CI command: shard 1 passed 7,619 tests and failed three untouched dependency/config/catalog tests; shard 3 passed 7,493 tests and failed eight untouched Alibaba quota-classification, call-log rotation, docs-count, CLI-catalog-count, andServiceSupervisortests. The strict docs-count failure is the same current-base drift tracked in #9985; none of the failing tests or source owners are changed by this PR.Checklist
Contributions
Made by Nathan.