Repository navigation
fix(radar): show activation before opt-in - #10487
Merged
Merged
Conversation
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…0487) Co-authored-by: Xiangzhe <bakryun0718@proton.me>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…0487) Co-authored-by: Xiangzhe <bakryun0718@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RADAR_ENABLEDavailability separate from the independent Radar sync opt-in/api/radar/settingsreturns200 { optIn: false }404behavior when the endpoint returns404Root cause
The dashboard overloaded
optIn === falseto mean both “feature flag off” and “feature available but owner has not opted in”. A fresh installation therefore callednotFound()immediately after the settings API correctly returned200 { optIn: false }.TDD / live reproduction
tests/unit/radar-optin-page.test.tsxreproducedsettings 200 + optIn false -> notFound()(2 calls)notFound()404still callsnotFound().15:/api/radar/settingsreturned200, followed by the rendered dashboard404Validation
npx vitest run tests/unit/radar-optin-page.test.tsx— 2/2npm run typecheck:core— greengit diff --check— green