Repository navigation
Conversation
…tryker tap.testFiles tests/unit/guardrails/visionBridge-responses-9597.test.ts covers open-sse/services/combo/comboStructure.ts but was missing from stryker.conf.json's tap.testFiles, so its mutant kills weren't counted — check-mutation-test-coverage.mjs --strict correctly flags this as drift, currently failing Fast Quality Gates on every open PR against release/v3.8.50 (reproduced on the pure tip before this fix).
Contributor
Author
|
Verified against current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/unit/guardrails/visionBridge-responses-9597.test.tsinstryker.conf.json'stap.testFiles— it coversopen-sse/services/combo/comboStructure.tsbut was missing from the list, so its mutant kills weren't counted.Root cause
check-mutation-test-coverage.mjs --strict(themutation-test-coveragegate in Fast Quality Gates) scans all unit test files for ones that exercise a mutated module and asserts every one of them is registered intap.testFiles. This one covering test drifted out of sync — currently failing this gate on every open PR againstrelease/v3.8.50, unrelated to whatever else the PR touches. Reproduced on the pure tip (6143da70d1) before this fix.Validation
node scripts/check/check-mutation-test-coverage.mjs --strict— clean (was failing before)node --import tsx --test tests/unit/guardrails/visionBridge-responses-9597.test.ts— 5/5 passpython3 -c "import json; json.load(open('stryker.conf.json'))"— valid JSONTests Added Or Updated
Coverage Notes
Reviewer Notes