Skip to content

fix(quality): register visionBridge-responses-9597 covering test in stryker tap.testFiles - #10264

Closed
hartmark wants to merge 1 commit into
diegosouzapw:release/v3.8.50from
hartmark:fix/mutation-coverage-comboStructure-tap-testfiles
Closed

hartmark wants to merge 1 commit into
diegosouzapw:release/v3.8.50from
hartmark:fix/mutation-coverage-comboStructure-tap-testfiles

Conversation

@hartmark

Copy link
Copy Markdown
Contributor

Summary

  • Registers tests/unit/guardrails/visionBridge-responses-9597.test.ts in stryker.conf.json's tap.testFiles — it covers open-sse/services/combo/comboStructure.ts but was missing from the list, so its mutant kills weren't counted.

Root cause

check-mutation-test-coverage.mjs --strict (the mutation-test-coverage gate in Fast Quality Gates) scans all unit test files for ones that exercise a mutated module and asserts every one of them is registered in tap.testFiles. This one covering test drifted out of sync — currently failing this gate on every open PR against release/v3.8.50, unrelated to whatever else the PR touches. Reproduced on the pure tip (6143da70d1) before this fix.

Validation

  • node scripts/check/check-mutation-test-coverage.mjs --strict — clean (was failing before)
  • node --import tsx --test tests/unit/guardrails/visionBridge-responses-9597.test.ts — 5/5 pass
  • python3 -c "import json; json.load(open('stryker.conf.json'))" — valid JSON

Tests Added Or Updated

  • None — this registers an existing test, no behavior change.

Coverage Notes

  • N/A, config-only change.

Reviewer Notes

…tryker tap.testFiles

tests/unit/guardrails/visionBridge-responses-9597.test.ts covers
open-sse/services/combo/comboStructure.ts but was missing from
stryker.conf.json's tap.testFiles, so its mutant kills weren't counted —
check-mutation-test-coverage.mjs --strict correctly flags this as drift,
currently failing Fast Quality Gates on every open PR against
release/v3.8.50 (reproduced on the pure tip before this fix).
@hartmark

Copy link
Copy Markdown
Contributor Author

Verified against current release/v3.8.50 (20ea78c94): stryker.conf.json's tap.testFiles already includes tests/unit/guardrails/visionBridge-responses-9597.test.ts (line 237) — this landed upstream through a different path since this PR was opened. Rebasing this branch drops the commit as redundant (patch contents already present), leaving zero diff. Closing as superseded.

@hartmark hartmark closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant