fix(combo): default chaos SSE to comment-only for OpenAI-compatible clients - #10128
Merged
diegosouzapw merged 5 commits intoAug 13, 2026
Merged
Conversation
…ouzapw#189, diegosouzapw#190) Bumps: nanoid ^3.3.17 (was transitive, now overridden), dompurify ^3.4.13 (with monaco-editor scoped override). Closes Dependabot diegosouzapw#189, diegosouzapw#190. Remaining diegosouzapw#182-diegosouzapw#188 (js-yaml + mermaid) already closed by diegosouzapw#9651 merge — awaiting Dependabot re-scan. npm audit → 0 vulnerabilities.
…egosouzapw#190 Closes Dependabot diegosouzapw#189 (dompurify 3.4.13) and diegosouzapw#190 (nanoid 3.3.17). npm audit → 0.
_tasks is a SEPARATE nested git repo (gitignored). The pattern _tasks/ (trailing slash) ignores only a directory, not a SYMLINK named _tasks. A self-referential _tasks symlink can slip in via git add -A and, once pulled, checkout materializes it over the real _tasks repo (destroying plans/specs/hands-off). Anchored /_tasks ignores the symlink too, preventing re-capture.
Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
diegosouzapw
merged commit Aug 13, 2026
a2e5bd1
into
diegosouzapw:release/v3.8.50
14 of 16 checks passed
Owner
|
Merged into |
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…lients (diegosouzapw#10128) * fix(deps): bump nanoid, dompurify for 2 new Dependabot alerts (diegosouzapw#189, diegosouzapw#190) Bumps: nanoid ^3.3.17 (was transitive, now overridden), dompurify ^3.4.13 (with monaco-editor scoped override). Closes Dependabot diegosouzapw#189, diegosouzapw#190. Remaining diegosouzapw#182-diegosouzapw#188 (js-yaml + mermaid) already closed by diegosouzapw#9651 merge — awaiting Dependabot re-scan. npm audit → 0 vulnerabilities. * fix(repo): harden .gitignore to also ignore a _tasks symlink (/_tasks) _tasks is a SEPARATE nested git repo (gitignored). The pattern _tasks/ (trailing slash) ignores only a directory, not a SYMLINK named _tasks. A self-referential _tasks symlink can slip in via git add -A and, once pulled, checkout materializes it over the real _tasks repo (destroying plans/specs/hands-off). Anchored /_tasks ignores the symlink too, preventing re-capture. * fix(combo): default chaos SSE to comment-only for OpenAI-compatible clients --------- Co-authored-by: diegosouzapw <diegosouzapw@users.noreply.github.com> Co-authored-by: Diego Rodrigues de Sa e Souza <diegosouza.pw@outlook.com> Co-authored-by: diegosouzapw <diegosouza.pw@gmail.com> Co-authored-by: herjarsa <herjarsa@users.noreply.github.com> Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
auto/chaosandauto/best-chaoscombos dispatch N models in parallel viahandleChaosChat, which emits a custom SSE eventevent: omni-chaos-partwith adata:payload carryingtype: "omni-chaos-part"metadata for every panel model.OpenAI SDK validators and
@ai-sdk/openai-compatibleexpect every SSEdata:line to match either{choices:[...]}(a chunk) or{error:...}. The customomni-chaos-partevent'sdata:line triggers a schema validationinvalid_unionerror on every auto/chaos stream, even for clients that never asked for the multi-panel protocol.Fix
Make the custom event opt-in via
stream_options.include_chaos_parts:event: omni-chaos-part+data: {type:"omni-chaos-part",...}emitted per model — breaks OpenAI SDK: chaos N ok/fail modelemitted per model (comments are ignored by all SSE parsers per spec)stream_options.include_chaos_parts: true)Changes
chaosEngine.ts:serializeChaosPart(part, isFinal, emitCustomEvent = false)— third param controls custom event emission.handleChaosChatreadsbody.stream_options?.include_chaos_partsand passes the flag through.chaosEngine.test.ts: 3 new test cases covering comment-only default, opt-in custom event, and error-all-fail path.Testing
chaosEngine.test.ts+chaosVirtualCombo.test.ts)Impact
include_chaos_partswill see custom events (they were already ignored by those clients).stream_options.include_chaos_parts: true.