Conversation
tiangao88
force-pushed
the
fix/gpt56-cross-provider-wire-format
branch
from
August 12, 2026 07:15
a4cc6a7 to
ea2b741
Compare
Contributor
Author
|
Closing as superseded by #9994 ("fix(providers): scope model-level targetFormat to declaring provider catalog"), which landed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v3.8.50 line added a global model-registry fallback to
getModelTargetFormat()(upstream commit3a66761cb, #8057). That fallback isuseful for sharing capability metadata, but it also inherited wire-format
metadata from unrelated provider registries.
OpenAI's GPT-5.6 registry entries declare
targetFormat: "openai-responses".When the same model ID was routed through the Nous or OpenRouter provider, the
fallback selected the Responses wire format even though those provider
connections dispatch to their Chat Completions endpoints. OmniRoute translated
messages[]into Responsesinput[], then sent that body to/chat/completions, producing:The failure reproduced with a two-message text-only request, with and without
reasoning_effort; it was not caused by compression or an image.Change
Make
getModelTargetFormat()provider-scoped again while retaining the usefulcross-provider global fallback for capability/model metadata:
*-proResponses heuristic;getProviderModel()and related capability fallback behavior unchanged.Expected behavior:
Tests
Extended
tests/unit/openai-gpt56-responses-routing.test.tswith coverage for:chatCoreprovider-default resolution;Focused test results:
Scope
This patch changes only model wire-format resolution and its regression tests.
It does not change provider credentials, routing combo membership, compression,
Vision Bridge settings, deployment configuration, or retry policy.