Skip to content

[TS7] fix(tinycms): align executor and signer contracts - #10087

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.50from
backryun:fix/ts7-tinycms-contracts
Aug 12, 2026
Merged

diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.50from
backryun:fix/ts7-tinycms-contracts

Conversation

@backryun

Copy link
Copy Markdown
Contributor

Summary

  • return TinyCMS success responses through the standard executor response envelope
  • remove the unreachable TextEncoder.encodeInto compatibility branch on the supported runtime
  • add a complete mocked success-path regression covering IP discovery, challenge acquisition, signing, and upstream response metadata

Validation

  • node --import tsx/esm --test tests/unit/provider-tinycms-web.test.ts — 16 passed
  • TypeScript 6.0.3: 52 → 49 diagnostics, removed 3, added 0
  • TypeScript 7.0.2: 52 → 49 diagnostics, removed 3, added 0
  • focused ESLint passed with the repository suppressions baseline

Related to #8484.

@backryun
backryun requested a review from diegosouzapw as a code owner August 11, 2026 10:17
@backryun
backryun force-pushed the fix/ts7-tinycms-contracts branch 16 times, most recently from 9609c44 to 2cd6ed4 Compare August 12, 2026 11:22
@backryun
backryun force-pushed the fix/ts7-tinycms-contracts branch from 2cd6ed4 to 2188bf8 Compare August 12, 2026 11:27
@diegosouzapw
diegosouzapw merged commit 5f5c0bc into diegosouzapw:release/v3.8.50 Aug 12, 2026
4 of 5 checks passed
@backryun
backryun deleted the fix/ts7-tinycms-contracts branch August 12, 2026 11:28
diegosouzapw added a commit that referenced this pull request Aug 12, 2026
…sh (#10198)

The Build CI job is advisory, so eight module-level defects from eight
different PRs accumulated on release/v3.8.50 until `npm run build` failed
with 7 Turbopack errors and `npm run lint` with 14.

Build (link-time):
- modelSelectModalHelpers.ts: a lost `}` swallowed PROVIDER_TEST_CHUNK_SIZE
  into isProviderModelHidden's body (#9011).
- videoGeneration.ts: handleFalVideoGeneration imported twice; the standalone
  falHandler.ts is superseded by the provider-neutral mediaGeneration/fal.ts
  and is removed here (#9982 over #9969).
- catalog.ts: re-exported and called the injectable SWR policy that #9199
  deliberately replaced with a fixed 30s bound. Fixed on the consumer side —
  restoring the accessor would resurrect the unbounded window #9199 removed
  after measuring a 41s catalog build in production.
- tinycmsSigner.ts: generated wasm-bindgen glue kept a sidecar
  `new URL('wasm_signer_bg.wasm', import.meta.url)` that no file backs;
  Turbopack resolves it statically. The module ships inlined as WASM_BASE64
  and the only caller always passes it explicitly (#8736/#10087).
- conolDiscovery.ts: imported getProviderOutboundGuard from outboundUrlGuard,
  which does not export it. Fixed on the consumer side: outboundUrlGuard.ts is
  loaded by the packaged CLI without a tsconfig, so it must stay free of
  `@/`-aliased imports (#7682).

Runtime (the build never caught this one):
- catalogCache.ts::scheduleBackgroundRefresh had two dangling statements
  referencing undeclared `inFlight`/`promise`, so EVERY stale-while-revalidate
  read threw a ReferenceError. Surfaced by realigning the #8728 suite, which
  #9199 left asserting a removed contract.

Lint:
- driverFactory.test.ts: a case inserted between the preceding test's `finally`
  and its `});` left the file unparseable, so the SQLite driver-cascade suite
  (26 tests) had not run since 2026-08-11 (#9173).
- providerModelsConfig.ts: imported an executor directly, crossing the G14
  boundary; routed through a new open-sse/services/zaiWebCredentials.ts (#8451).
- image-combo.test.ts: 11 `any` violations, now typed (#9499).

Validation: npm run build exit 0, npm run lint clean, typecheck:core clean,
41/41 tests green across the affected suites.

Refs #9011 #9982 #9199 #8728 #8736 #10087 #8974 #9173 #8451 #9499

Co-authored-by: backryun <bakryun0718@proton.me>
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…sh (diegosouzapw#10198)

The Build CI job is advisory, so eight module-level defects from eight
different PRs accumulated on release/v3.8.50 until `npm run build` failed
with 7 Turbopack errors and `npm run lint` with 14.

Build (link-time):
- modelSelectModalHelpers.ts: a lost `}` swallowed PROVIDER_TEST_CHUNK_SIZE
  into isProviderModelHidden's body (diegosouzapw#9011).
- videoGeneration.ts: handleFalVideoGeneration imported twice; the standalone
  falHandler.ts is superseded by the provider-neutral mediaGeneration/fal.ts
  and is removed here (diegosouzapw#9982 over diegosouzapw#9969).
- catalog.ts: re-exported and called the injectable SWR policy that diegosouzapw#9199
  deliberately replaced with a fixed 30s bound. Fixed on the consumer side —
  restoring the accessor would resurrect the unbounded window diegosouzapw#9199 removed
  after measuring a 41s catalog build in production.
- tinycmsSigner.ts: generated wasm-bindgen glue kept a sidecar
  `new URL('wasm_signer_bg.wasm', import.meta.url)` that no file backs;
  Turbopack resolves it statically. The module ships inlined as WASM_BASE64
  and the only caller always passes it explicitly (diegosouzapw#8736/diegosouzapw#10087).
- conolDiscovery.ts: imported getProviderOutboundGuard from outboundUrlGuard,
  which does not export it. Fixed on the consumer side: outboundUrlGuard.ts is
  loaded by the packaged CLI without a tsconfig, so it must stay free of
  `@/`-aliased imports (diegosouzapw#7682).

Runtime (the build never caught this one):
- catalogCache.ts::scheduleBackgroundRefresh had two dangling statements
  referencing undeclared `inFlight`/`promise`, so EVERY stale-while-revalidate
  read threw a ReferenceError. Surfaced by realigning the diegosouzapw#8728 suite, which
  diegosouzapw#9199 left asserting a removed contract.

Lint:
- driverFactory.test.ts: a case inserted between the preceding test's `finally`
  and its `});` left the file unparseable, so the SQLite driver-cascade suite
  (26 tests) had not run since 2026-08-11 (diegosouzapw#9173).
- providerModelsConfig.ts: imported an executor directly, crossing the G14
  boundary; routed through a new open-sse/services/zaiWebCredentials.ts (diegosouzapw#8451).
- image-combo.test.ts: 11 `any` violations, now typed (diegosouzapw#9499).

Validation: npm run build exit 0, npm run lint clean, typecheck:core clean,
41/41 tests green across the affected suites.

Refs diegosouzapw#9011 diegosouzapw#9982 diegosouzapw#9199 diegosouzapw#8728 diegosouzapw#8736 diegosouzapw#10087 diegosouzapw#8974 diegosouzapw#9173 diegosouzapw#8451 diegosouzapw#9499

Co-authored-by: backryun <bakryun0718@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants