fix(mcp): move pack validation out of unit suite - #10065
Merged
diegosouzapw merged 2 commits intoAug 13, 2026
Merged
Conversation
yansigit
marked this pull request as ready for review
August 11, 2026 04:50
diegosouzapw
merged commit Aug 13, 2026
ef5703c
into
diegosouzapw:release/v3.8.50
13 of 14 checks passed
Owner
|
Merged into |
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm packsubprocess from the concurrent MCP files unit test.check:pack-artifact/check:pack-policyto reject packed test/spec files and missing MCP closure paths, including npm workspace JSON output.Related Issues
--mcpflag #3578Validation
npm run lint— inherited base failures intests/unit/combo/image-combo.test.ts(anyviolations; introduced by base feat(images): add full combo strategy execution for image generation (#9239) #9499) andopen-sse/config/providers/registry/deepai/index.ts(missing../shared; introduced by base feat(providers): add DeepAI as paid image provider (#6671) #9443)npm run typecheck:core— same inherited DeepAI base failurenpm run check:pack-policynpm run check:changelog-integrityrelease/v3.8.50base (5fd2325)Tests Added Or Updated
tests/unit/mcp-published-files-closure-3578.test.tstests/unit/mcp-published-files-closure-helpers.test.tstests/unit/pack-artifact-policy.test.tsCoverage Notes
This changes build/validation scripts rather than
src/,open-sse/,electron/, orbin/runtime code. The focused policy tests cover the new closure, test-leak, and npm-output parsing helpers.Reviewer Notes
The real pack walk remains intentionally in the dedicated pack-artifact gate and uses
--ignore-scripts; the concurrent unit suite now performs only static checks and completes in milliseconds.release/v3.8.50base currently has an open release-green issue. After reconciling with the current base (5fd2325), the full lint/typecheck failures remain outside this PR diff in the two files listed above; they are inherited and are not introduced by this branch.