Skip to content

fix(mcp): move pack validation out of unit suite - #10065

Merged
diegosouzapw merged 2 commits into
diegosouzapw:release/v3.8.50from
yansigit:fix/mcp-pack-unit-stall
Aug 13, 2026
Merged

diegosouzapw merged 2 commits into
diegosouzapw:release/v3.8.50from
yansigit:fix/mcp-pack-unit-stall

Conversation

@yansigit

@yansigit yansigit commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove the live npm pack subprocess from the concurrent MCP files unit test.
  • Share the static MCP import-closure and package-file policy helpers between unit tests and the pack gate.
  • Extend check:pack-artifact / check:pack-policy to reject packed test/spec files and missing MCP closure paths, including npm workspace JSON output.

Related Issues

Validation

Tests Added Or Updated

  • tests/unit/mcp-published-files-closure-3578.test.ts
  • tests/unit/mcp-published-files-closure-helpers.test.ts
  • tests/unit/pack-artifact-policy.test.ts

Coverage Notes

This changes build/validation scripts rather than src/, open-sse/, electron/, or bin/ runtime code. The focused policy tests cover the new closure, test-leak, and npm-output parsing helpers.

Reviewer Notes

The real pack walk remains intentionally in the dedicated pack-artifact gate and uses --ignore-scripts; the concurrent unit suite now performs only static checks and completes in milliseconds.

⚠️ base-red inherited: #9985. The active release/v3.8.50 base currently has an open release-green issue. After reconciling with the current base (5fd2325), the full lint/typecheck failures remain outside this PR diff in the two files listed above; they are inherited and are not introduced by this branch.

@yansigit
yansigit marked this pull request as ready for review August 11, 2026 04:50
@yansigit
yansigit requested a review from diegosouzapw as a code owner August 11, 2026 04:50
@diegosouzapw
diegosouzapw merged commit ef5703c into diegosouzapw:release/v3.8.50 Aug 13, 2026
13 of 14 checks passed
@diegosouzapw

Copy link
Copy Markdown
Owner

Merged into release/v3.8.50 — thank you @yansigit for the contribution! It was validated on a combined merge-train (static gates + affected tests + vitest) together with 30 sibling PRs before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants