Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional propDescriptions #7

Closed
wants to merge 1 commit into from
Closed

Add optional propDescriptions #7

wants to merge 1 commit into from

Conversation

dennisreimann
Copy link

Fixes #6

@codecov-io
Copy link

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          39     41    +2     
  Branches       10     12    +2     
=====================================
+ Hits           39     41    +2
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b4db9...9a5db73. Read the comment docs.

@naltatis
Copy link

This would be a great feature. @diegohaz Any chance getting this merged?

@dennisreimann
Copy link
Author

Can you provide feedback on this, @diegohaz? Anything I can do to get this merged? Otherwise I'd close this PR.

@diegohaz
Copy link
Owner

I'm sorry for not showing up, guys. I've been very busy.

I'm still worried about the unnecessary weight it would add to the users' bundle since strings are not minified.

But, people seem to want this, so I guess we should merge it. Maybe we should just add a note on README warning about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intention to parse/extract description?
4 participants