-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Storyshots - Closes #96 #101
Conversation
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
======================================
Coverage 100% 100%
======================================
Files 39 76 +37
Lines 257 409 +152
Branches 51 51
======================================
+ Hits 257 409 +152
Continue to review full report at Codecov.
|
Thank you very much for your work, @abhishekisnot. Now we have a good view of what it would look like with The problem is everything we add to the boilerplate is one more thing for new developers to figure out. And, honestly, analyzing the snapshots, I don't think it's worth it. Most of them are just |
I didn't know about the Can you put that in a separate PR? |
Yeah, from value proposition, this makes sense. Thank you for considering the feature. |
Just a sidenote, if we do not mock the component for tests, I start getting errors on Jest tests as:
It seems, Jest does not/won't support dynamic requires as mentioned here: |
Yeah, Jest doesn't support that. And that's another reason to mock components. I agree with Dan. Anyway, thank you, @abhishekisnot. I'll close this PR, but I think it's still valuable as a reference for one wanting to add this feature to their projects. |
What does this PR addresses ?
test
directory to__test__
which aligns more with what Jest expects. The jest snapshot directory then is__test__/__snapshots__
What would this PR change ?
Tests BEFORE:


Tests AFTER:
Coverage BEFORE:


Coverage AFTER: