Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tcmd commands and docs #929

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

comodoro
Copy link
Contributor

@comodoro comodoro commented Aug 3, 2022

Several new TC commands

Description

Just a few commands using keystrokes

How Has This Been Tested

Just rule and docs changes, tested by using

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue or bug)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Renamed existing command phrases (we discourage this without a strong rationale).

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have checked that my code does not duplicate functionality elsewhere in Caster.
  • I have checked for and utilized existing command phrases from within Caster (delete if not applicable).
  • Navigation commands overwrite application commands? Thought it would be the other way around, because of this tab navigation cannot just be overriden. Besides, tab movement in caster navigation currently uses ctrl+pgup/down. Not sure if it is possible, but switching to ctrl+tab/shift+tab would eliminate the need to override them in tc.
  • My code implements all the features I wish to merge in this pull request.
  • My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • N/A
  • All new and existing tests pass.
  • N/A

Maintainer/Reviewer Checklist

  • Basic functionality has been tested and works as claimed.
  • New documentation is clear and complete.
  • Code is clear and readable.

@LexiconCode LexiconCode changed the base branch from master to DropPy2 August 31, 2022 01:21
@LexiconCode LexiconCode changed the base branch from DropPy2 to master August 31, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant