Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Catppuccin themes #560

Merged
2 commits merged into from
Jun 8, 2024
Merged

Add Catppuccin themes #560

2 commits merged into from
Jun 8, 2024

Conversation

cswimr
Copy link
Contributor

@cswimr cswimr commented Jun 7, 2024

This PR adds Catppuccin themes to v3. v4 PR will come later as well, don't have the time for it at the moment.

image
image
image
image

@diced
Copy link
Owner

diced commented Jun 7, 2024

This might just be my personal preference, but the appshell background color on catppuccin_latte seems a bit too dark, and isn't really fitting into the light theme. I think it would be better if it was a bit lighter. The other themes look great, and feel free to take your time bringing them over to v4.

Also the palette link on all of them are misspelled, instead of https://catppuccin.com/pallete it should be https://catppuccin.com/palette

@cswimr
Copy link
Contributor Author

cswimr commented Jun 7, 2024

Alright, I can look at it later. All of the colors I'm using are from https://catppuccin.com/palette (with the exception of the accenting colors, which are variations of each theme's Blue accent), so if there's another color from Latte that you think would look better as the appshell background, I can swap it around.

@diced diced closed this pull request by merging all changes into diced:trunk in 08d3bfb Jun 8, 2024
@diced
Copy link
Owner

diced commented Jun 8, 2024

💀 didn't mean to do that whoops

@diced
Copy link
Owner

diced commented Jun 8, 2024

well what I meant to do was in this commit 5e37d89

for some reason mantine doesn't let you even change the light colors for light themes, so the workaround here is just setting the color scheme to dark, but using the light colors. it works so whatever :)

@NeonGamerBot-QK
Copy link

catppuccin :D

@NeonGamerBot-QK
Copy link

@cswimr you should prob create an issue at the catpuccin repo if you added this to zipline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants