Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix util method to check if variable is not null #458

Merged
merged 4 commits into from
Sep 9, 2023

Conversation

kashalls
Copy link
Contributor

@kashalls kashalls commented Sep 3, 2023

When the serverside middleware checks to see if any of the oauth providers are enabled, it checks to see if the config is not null.
In node, the nullish operator ? returns undefined instead of spewing a nasty error.

Config checks to see if it is not null.

> null === undefined
false

Fixes #457

@github-actions github-actions bot added this to the 3.7.1 milestone Sep 3, 2023
Copy link
Collaborator

@TacticalTechJay TacticalTechJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TacticalTechJay TacticalTechJay merged commit 28db15e into diced:trunk Sep 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Enabling oauth registration shows all oauth providers even if unconfigured.
2 participants