Worst fix ever. #407
Merged
Worst fix ever. #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diced
approved these changes
May 22, 2023
SinonCute
pushed a commit
to SinonCute/zipline
that referenced
this pull request
Jun 30, 2023
* fix: Worst, but minimally working, fix so other users do not delete each other's files. * fix: include previous fix for PATCH --------- Co-authored-by: dicedtomato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be P1~P0 as it fixes an issue where any user can delete another user's file. All they have to do is guess the numbered id of a file. This fix will only allow admins or superAdmins to delete other user's files.