feat: offloaded chunked uploads #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diced
requested review from
TacticalTechJay
and removed request for
TacticalTechJay
|
PR needs to update to reflect changes with tmp_directory, etc. |
TacticalTechJay
approved these changes
Apr 3, 2023
Just to dismiss any misunderstandings, the workers are only used for partial uploads. I will merge this tomorrow with a environment variable that disables chunked uploads entirely for users who do not need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses node workers to offload all chunked uploads into its own "thread". Users can view pending uploads within the files tab, and see their progress.
Very unstable, not tested thoroughly.