-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream post_file
#34
Merged
Merged
Stream post_file
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efactor file_stream to use explicit FileStream type alias (#35)
…variable in tests.
…do folder in the home directory. Configurable drive redundancy.
rustchain64
approved these changes
May 1, 2023
rustchain64
reviewed
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
cryptoquick
added a commit
that referenced
this pull request
May 4, 2023
* Stream `post_file` (#34) * Implement HTTP body streaming version of post_file. * Refactor streaming interface format. Fix tests. * Reduce number of files created in test by increasing chunk size to 1MB. * Fix check catalog_exists test. Cleanup unused libraries. * Log node public key in config. Correct Error Message in fs backend. Refactor file_stream to use explicit FileStream type alias (#35) * Update carbonado to 0.3.0-rc.7 and secp256k1 to 0.27.0. Fix misnamed variable in tests. * Add drive_redundancy option to config. * Update directories crate. Default volume directory is now the Carbonado folder in the home directory. Configurable drive redundancy. * Fixes in response to review items. --------- Co-authored-by: Wesley Parr <[email protected]> * Merge main. * Streaming improvements (#37) * Update unfold in write method to produce stream chunks of uniform segment size. * Parallelize write_file. Add config node_shared_secret method and /key endpoint. Improve tests. * Debugging... * Fixes. * Stream read file using axum response StreamBody. Parallelized decoding using par_then. * Cleanup. * Cleanup. --------- Co-authored-by: Wesley Parr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows large files to safely be streamed to the endpoint.