Split up engine.{h,cpp}
#7625
Split up engine.{h,cpp}
#7625
Conversation
Source/engine/width2.hpp
Outdated
| * Width2 is needed for savegame compatibility and to render animations centered | ||
| * @return Returns Width2 | ||
| */ | ||
| constexpr int CalculateWidth2(int width) |
There was a problem hiding this comment.
- GetRenderingOffset()
- CalculateHorizontalOffset()
- CalculateCenterOffset()
- CalculateSpriteCenter()
Move it to one of the rendering headers, probably primitive_render.cpp.
There was a problem hiding this comment.
These are all kinda inaccurate because the function only works on sprite with width 64 (?). Is it OK if we leave this for a future PR?
We can then figure out a name, perhaps something like CalculateSpriteCenter64?
A rendering header also is not ideal because then loadsave would depend on rendering.
There was a problem hiding this comment.
Considering that saveload is trying to stay compatible with a memory dump of a not to well thought out format I think that isn't to much of an issue.
It would be nice if we could resolve it as part of this PR as not to complicated and we have kept putting it off. This PR is dealing with where to put things and what to name them (at least the new places) so I don't think it's to out of scope either. CalculateSpriteCenter64 is an ok name.
There was a problem hiding this comment.
I'm having trouble coming up with a good description for the function because I don't quite understand how it's used (I also have a flu so that could be why 🤧).
I don't think it should be in the rendering code (loadsave should not depend on rendering, it'd defeat the purpose of splitting things up), perhaps in util/sprite_width64.hpp or something?
There was a problem hiding this comment.
i guess that would be ok. It doesn't need to be perfect, just a bit better then what's there :)
There was a problem hiding this comment.
Could the 64px be in reference to the tile size and not related to the actual sprite per say? Meaning it's finding the center of the sprite and placing it at the center of the tile.
There was a problem hiding this comment.
I think that might be it!
Renamed to CalculateSpriteTileCenterX and moved to levels/dun_tile.hpp.
Untangles dependencies by splitting up `engine.{h,cpp}` into 3 files:
1. `primitive_render`
2. `ticks` -- only contains `GetAnimationFrame` for now.
3. `GetWidth2` renamed to `CalculateSpriteTileCenterX` and moved to `levels/dun_tile.hpp`.
| */ | ||
| constexpr int CalculateSpriteTileCenterX(int width) | ||
| { | ||
| return (width - TILE_WIDTH) / 2; |
Untangles dependencies by splitting up
engine.{h,cpp}into 3 files:engine/render/primitive_render.{hpp,cpp}engine/ticks.{hpp,cpp}-- only containsGetAnimationFramefor now.GetWidth2renamed toCalculateSpriteTileCenterXand moved tolevels/dun_tile.hpp.GetDirection(Point, Point)is moved intopoint.