Split endian_write from endian #7620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only `endian_write` functions require SDL, splitting them out will allow us to clean up the dependencies a bit.
yuripourre
approved these changes
Jan 7, 2025
AJenbo
approved these changes
Jan 8, 2025
|
Thanks to both of you |
|
@AJenbo my pleasure! When is not too complicated I can help! |
glebm
added a commit
to glebm/devilutionX
that referenced
this pull request
Jan 8, 2025
Following diasurgical#7620, which split the write functions into a separate header.
glebm
added a commit
that referenced
this pull request
Jan 8, 2025
Following #7620, which split the write functions into a separate header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only
endian_writefunctions require SDL, splitting them out will allow us to clean up the dependencies a bit.Extracted from #7554