storm_svid: use DISPLAY_TEXTURE_FORMAT also for SVidPlayEnd #7604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise we get incorrect menu graphics
AJenbo
approved these changes
Dec 26, 2024
Please send a PR with the cherry-pick for the 1.5 branch! 👍 |
|
What's the device you are building it for? I'm guessing some kind of Miyoo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm testing it on platform which operates on RGB565 soly (sdl-directfb) and without this patch we get incorrect menu graphics. Moreover if you not define correct DISPLAY_TEXTURE_FORMAT before compiling, then SDL_HINT_RENDER_SCALE_QUALITY have no effect for DirectFB and the default value is picked by render for all scaling options.
BTW: Compiled via
1.5branch because our older gcc 9.4.0 doesn't supportstd::span, so I've small request to cherry-pick this and c2ad6da commit to stable branch 🙏