Fix MSVC warnings in utils\* #6808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes remaining MSVC warnings in utils (see related discussion).
I added
_SILENCE_CXX20_U8PATH_DEPRECATION_WARNINGto CMake, because adding it before the header include didn't work._SILENCE_ALL_CXX20_DEPRECATION_WARNINGSis checked inyvals_core.hthat has a#pragma onceand is included by some other header before.So I that's why I thought the least error-prone variant is to set the define in CMake.
This PR reduces warnings by 6 (from 246 to 240).