Migrate item data to txtdata/ #6802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
force-pushed
the
itemdat
branch
2 times, most recently
from
48be235 to
b2b3127
Compare
glebm
changed the title
AllItemsList to itemdat.tsv(unique_)itemdat.tsv
glebm
force-pushed
the
itemdat
branch
2 times, most recently
from
ca63879 to
9583c92
Compare
glebm
changed the title
(unique_)itemdat.tsv
glebm
force-pushed
the
itemdat
branch
2 times, most recently
from
d7f19c7 to
bafac8e
Compare
AJenbo
reviewed
Nov 13, 2023
AJenbo
reviewed
Nov 13, 2023
|
|
||
| tl::expected<item_misc_id, std::string> ParseItemMiscId(std::string_view value) | ||
| { | ||
| if (value == "NONE") return IMISC_NONE; |
There was a problem hiding this comment.
Only comment is that I think it would be good if we changed these to follow CamelCase like the enum classes, even if we haven't done so internally yet. That way it's more consistent and hopefully also stable.
But I think this might also have been the case for some of the other files so I don't think that has to be a blocker for this one.
There was a problem hiding this comment.
Sure, I agree. I think renaming things is a separate thing from extracting things to data files though. Here I've simply removed a prefix, which is an automatic edit. It is easier to review renames separately.
Not planning to do the renaming myself anytime so feel free to take this up.
AJenbo
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also simplifies txtdata parsing with a helper class (
RecordReader).