Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

816-NEW-dashboard-add-text #855

Merged
merged 52 commits into from
Oct 3, 2024
Merged

816-NEW-dashboard-add-text #855

merged 52 commits into from
Oct 3, 2024

Conversation

elboyran
Copy link
Contributor

Issue #816

Remove broken link to dashboard screenshot. Placeholder for a new one.
Removed broken link old dashboard screenshot. Placeholder for a new one.
@elboyran elboyran linked an issue Sep 20, 2024 that may be closed by this pull request
9 tasks
@laurasootes
Copy link
Contributor

laurasootes commented Sep 23, 2024

@elboyran I like the text for the home page! I left a few small comments on the text.

I also fixed the dashboard tests, they all pass now

@elboyran
Copy link
Contributor Author

@elboyran I like the text for the home page! I left a few small comments on the text.

I also fixed the dashboard tests, they all pass now

Thanks! I'll keep working in this PR on the remaining task in issue #816 .

@elboyran
Copy link
Contributor Author

elboyran commented Oct 2, 2024

@cwmeijer did you find out why your PRs notebook checks are failing?

@elboyran
Copy link
Contributor Author

elboyran commented Oct 2, 2024

The macos-related checks are failing, not related to this PR.

@laurasootes
Copy link
Contributor

@elboyran I added the collapsable section, do you like it this way?
If so, I think we can merge this

@elboyran
Copy link
Contributor Author

elboyran commented Oct 3, 2024

Hi @laurasootes , I like it a lot.

  1. Do you think it makes sense the description to appear below or maybe better still above the example text (in its "original" place)?
  2. The colormap image now is shifted to the right and looks displaced from the text above. I will try to fix it and maybe remove the end of lines after all as you suggested if that will alight it better ;-)

@elboyran elboyran marked this pull request as draft October 3, 2024 09:26
@laurasootes
Copy link
Contributor

@elboyran

  1. I was wondering the same thing, not sure what makes the most sense. I can move it up if you think that’s better.
  2. I indeed centered the colormap image, I thought that makes sure that the eye of the user is also directed to the instruction below “Select which input type to use in the left panel to continue”

@elboyran
Copy link
Contributor Author

elboyran commented Oct 3, 2024

@elboyran

1. I was wondering the same thing, not sure what makes the most sense. I can move it up if you think that’s better.

2. I indeed centered the colormap image, I thought that makes sure that the eye of the user is also directed to the instruction below “Select which input type to use in the left panel to continue”

@laurasootes

  1. Please, go ahead with moving it up.
  2. Maybe the image should be where it was, and I will think about how to make the instruction more prominent.

@laurasootes
Copy link
Contributor

@elboyran I moved up the texted and removed the centering of the image.
In the end the difference is this (also including the difference in yes/no line breaks), I guess it does not matter that much for the instruction with the image on the left.

Screenshot 2024-10-03 at 12 11 34 Screenshot 2024-10-03 at 12 12 10

separating line between description explanation and the example text for images
separating line between description explanation and the example text Tabular
separating line between description explanation and the example text: Text
separating line between description explanation and the example text: Tabular classification
separating line between description explanation and the example text: Time series
@elboyran elboyran marked this pull request as ready for review October 3, 2024 11:59
@elboyran elboyran merged commit 1755e0b into main Oct 3, 2024
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FRB example fails in dashboard Dashboard: add text
2 participants