Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

789 add tabular example in dashboard and more example upgrades #847

Merged
merged 102 commits into from
Sep 18, 2024

Conversation

laurasootes
Copy link
Contributor

@laurasootes laurasootes commented Aug 28, 2024

Builds on PR #838, so that one has to be approved first

This PR adds a number of things to the dashboard:

  • Tabular regression example sunshine hours.
  • Tabular classification example penguin identification. Fixes Add tabular example in dashboard #789
  • sets for various examples in the dashboard the default parameters equal to those used in the example notebooks
  • allows the user to change the text input for the movie example, as per dashboard: allow for own input in examples #835
  • add the image of the original FRB signal to the example, to show it side by side with the explanation
  • adds tests for the tabular examples
  • fixes the timeout error for the dashboard test Tests for the dashboard #567
  • fixes the rendering of the menu as top only when dianna-dashboard installation is used

table,
method='LIME',
training_data=training_data,
feature_names=_feature_names,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is still present, is it needed? The other PR deemed this as a temp solution to setting the number classes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I believe so, the temporary solution originates from pr #641 and is mentioned in issue #801, but has not been fixed. Once that is fixed, it can be fixed here.

dianna/dashboard/_shared.py Outdated Show resolved Hide resolved
dianna/dashboard/pages/Tabular.py Outdated Show resolved Hide resolved
@elboyran
Copy link
Contributor

Nice work, @laurasootes !

@elboyran
Copy link
Contributor

For fixing the conflicting files, consider the latest change

@elboyran
Copy link
Contributor

To fix the DOI in #854.

@elboyran elboyran merged commit f742047 into main Sep 18, 2024
16 of 18 checks passed
@elboyran elboyran deleted the 789-add-tabular-example-in-dashboard branch October 2, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tabular example in dashboard
2 participants