-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
838 create tabular tab to dashboard and redesign loaded data results #819 #844
Conversation
…amples' of https://github.com/dianna-ai/dianna into 819-dashboard-redesign-loaded-data-results
…//github.com/dianna-ai/dianna into 819-dashboard-redesign-loaded-data-results
…//github.com/dianna-ai/dianna into 819-dashboard-redesign-loaded-data-results
…//github.com/dianna-ai/dianna into 819-dashboard-redesign-loaded-data-results
…reate-tabular-tab-to-dashboard
@@ -63,6 +63,7 @@ def __init__( | |||
LimeTabularExplainer, kwargs) | |||
|
|||
# temporary solution for setting num_features and top_labels | |||
# when fixed, also fix in dashboard Tabular.py -> _feature_names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it fixed in the next PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the temporary fix itself was already here, it has been added in december PR 661. I did not try to fix the general problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe issue 801 mentions the general issue
This PR adds a tabular page to the dashboard (#838 ) and finalises all dashboard redesigns (#819 ).
Tabular page:
Page is implemented similar to the other pages (text, images, time series).
Dashboard redesign changes:
Other changes:
fixes #838 and fixes #819 and fixes #523