813 clean model folder #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to fix the linting errors.
…into 813-clean-model-folder
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@laurasootes any idea why the dashboard test is failing? I think it's not related to the removed models/data by this PR, but am not sure. |
|
To DO: fix the remaining issues in the RISE tabular penguin. |
Closed
|
I compared the files still present in the model folder with the downloader script and all seems to match - nice cleanup work! |
|
[like] Elena Ranguelova reacted to your message:
…________________________________
From: Leon Oostrum ***@***.***>
Sent: Tuesday, July 16, 2024 11:36:00 AM
To: dianna-ai/dianna ***@***.***>
Cc: Elena Ranguelova ***@***.***>; Author ***@***.***>
Subject: Re: [dianna-ai/dianna] 813 clean model folder (PR #824)
I compared the files still present in the model folder with the downloader script and all seems to match - nice cleanup work!
—
Reply to this email directly, view it on GitHub<#824 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAYYBWMLZ4VVVRFQCCGZHCLZMUASBAVCNFSM6AAAAABK4K62LOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQGY3TCNZWGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
cwmeijer
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed from the repo the models and data that can be downloaded from Zenodo.