Skip to content

Update CI#289

Merged
elboyran merged 2 commits intomainfrom
update_CI
Apr 5, 2022
Merged

Update CI#289
elboyran merged 2 commits intomainfrom
update_CI

Conversation

@egpbos
Copy link
Member

@egpbos egpbos commented Mar 29, 2022

Three updates in this PR:

  1. Update GitHub actions versions (necessary because the old ones will soon stop working).
  2. Simplify the release workflow: use the build module to build wheels and source distribution in one go, as recommended here: https://packaging.python.org/en/latest/tutorials/packaging-projects/#generating-distribution-archives
  3. Streamline the release workflow: only trigger the test.pypi upload when manually running the workflow. Before, it would also trigger on releases, but this is unnecessary. This way, the test.pypi.org channel can also be used to test an upload without having to bump the version.

egpbos added 2 commits March 29, 2022 16:08
v3 of these actions uses the new runtime. The old runtime will be end-of-life in May.
Simplify: use only one command to build both the wheel and source distribution using the build module, as recommended by packaging.python.org

Streamline: only trigger the upload_test_pypi job when manually running the workflow. Before, it would also trigger on releases, but this is unnecessary. This way, the test.pypi.org channel can also be used to test an upload without having to bump the version.
@egpbos egpbos requested a review from loostrum March 29, 2022 14:14
@egpbos
Copy link
Member Author

egpbos commented Mar 30, 2022

Note that CI is failing due to this upstream error: fastapi/typer#377, which will be fixed by this PR: fastapi/typer#375 so we should wait for that.

@tiangolo
Copy link

Hello! I just released Typer 0.4.1 that should handle this. 🚀 🤓

@egpbos
Copy link
Member Author

egpbos commented Mar 31, 2022

Awesome, thanks for the ping @tiangolo!

@elboyran elboyran merged commit 61b9a5b into main Apr 5, 2022
@geek-yang geek-yang deleted the update_CI branch April 3, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants