-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting CI is broken #423
Comments
We already install prospector[with_pyroma] exactly as suggested in the screenshot and it worked before. Perhaps an update to prospector/pyroma broke this |
Highly likely. There was an update yesterday: https://pypi.org/project/prospector/#history Also an update three hours ago, so maybe it was fixed. But looking at the log of that run, I also see this: Not sure if 1.8.2 fixes that... |
Maybe just try installing pyroma explicitly? Or disable it in linting config, not sure what it does or whether it is even used here anyway (it gives a score, not a fail/pass, I think). |
Ah good catch. There's already an open issue in the prospector repo: prospector-dev/prospector#545 |
I'm also not sure what pyroma actually does. I opened a PR with the least-effort way of getting it to run again: pinning the version |
Version 1.8.4 should have fixed the issues previously mentioned in #423. See https://github.com/PyCQA/prospector/milestone/7?closed=1.
See the following screenshot from https://github.com/dianna-ai/dianna/actions/runs/3593771040/jobs/6051161094:
The text was updated successfully, but these errors were encountered: