Test: CI/CD workflow fixes from PR #4223

.github/CODEOWNERS

@@ -0,0 +1,6 @@
+# CODEOWNERS file for block/goose repository
+# See: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
+
+# Documentation owned by DevRel team
+/documentation/ @block/goose-devrel
+

.github/workflows/build-cli.yml

@@ -17,7 +17,7 @@ on:
       ref:
         type: string
         required: false
-        default: 'refs/heads/main'
+        default: ""
 
 name: "Reusable workflow to build CLI"
 

.github/workflows/bundle-desktop-intel.yml

@@ -24,22 +24,9 @@ on:
       ref:
         type: string
         required: false
-        default: 'refs/heads/main'
+        default: ''
     secrets:
-      CERTIFICATE_OSX_APPLICATION:
-        description: 'Certificate for macOS application signing'
-        required: false
-      CERTIFICATE_PASSWORD:
-        description: 'Password for the macOS certificate'
-        required: false
-      APPLE_ID:
-        description: 'Apple ID for notarization'
-        required: false
-      APPLE_ID_PASSWORD:
-        description: 'Password for the Apple ID'
-        required: false
-      APPLE_TEAM_ID:
-        description: 'Apple Team ID'
+      OSX_CODESIGN_ROLE:
         required: false
 
 name: Reusable workflow to bundle desktop app for Intel Mac
@@ -48,41 +35,19 @@ jobs:
   bundle-desktop-intel:
     runs-on: macos-latest
     name: Bundle Desktop App on Intel macOS
+    permissions:
+      id-token: write
+      contents: read
     steps:
       # Check initial disk space
       - name: Check initial disk space
         run: df -h
 
-      # Validate Signing Secrets if signing is enabled
-      - name: Validate Signing Secrets
-        if: ${{ inputs.signing }}
-        run: |
-          if [[ -z "${{ secrets.CERTIFICATE_OSX_APPLICATION }}" ]]; then
-            echo "Error: CERTIFICATE_OSX_APPLICATION secret is required for signing."
-            exit 1
-          fi
-          if [[ -z "${{ secrets.CERTIFICATE_PASSWORD }}" ]]; then
-            echo "Error: CERTIFICATE_PASSWORD secret is required for signing."
-            exit 1
-          fi
-          if [[ -z "${{ secrets.APPLE_ID }}" ]]; then
-            echo "Error: APPLE_ID secret is required for signing."
-            exit 1
-          fi
-          if [[ -z "${{ secrets.APPLE_ID_PASSWORD }}" ]]; then
-            echo "Error: APPLE_ID_PASSWORD secret is required for signing."
-            exit 1
-          fi
-          if [[ -z "${{ secrets.APPLE_TEAM_ID }}" ]]; then
-            echo "Error: APPLE_TEAM_ID secret is required for signing."
-            exit 1
-          fi
-          echo "All required signing secrets are present."
-
       - name: Checkout code
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
         with:
-          ref: ${{ inputs.ref }}
+          # Only pass ref if it's explicitly set, otherwise let checkout action use its default behavior
+          ref: ${{ inputs.ref != '' && inputs.ref || '' }}
           fetch-depth: 0
 
       # Update versions before build
@@ -98,22 +63,6 @@ jobs:
           cd ui/desktop
           npm version ${{ inputs.version }} --no-git-tag-version --allow-same-version
 
-      # Pre-build cleanup to ensure enough disk space
-      - name: Pre-build cleanup
-        run: |
-          source ./bin/activate-hermit
-          echo "Performing pre-build cleanup..."
-          # Clean npm cache
-          npm cache clean --force || true
-          # Clean any previous build artifacts
-          rm -rf target || true
-          # Clean Homebrew cache
-          brew cleanup || true
-          # Remove unnecessary large directories
-          rm -rf ~/Library/Caches/* || true
-          # Check disk space after cleanup
-          df -h
-
       - name: Cache Cargo registry
         uses: actions/cache@2f8e54208210a422b2efd51efaa6bd6d7ca8920f # pin@v3
         with:
@@ -185,14 +134,16 @@ jobs:
           cp temporal-service/temporal-service ui/desktop/src/bin/temporal-service
           cp bin/temporal ui/desktop/src/bin/temporal
 
-      - name: Add MacOS certs for signing and notarization
-        if: ${{ inputs.signing }}
-        run: ./scripts/add-macos-cert.sh
-        working-directory: ui/desktop
-        env:
-          CERTIFICATE_OSX_APPLICATION: ${{ secrets.CERTIFICATE_OSX_APPLICATION }}
-          CERTIFICATE_PASSWORD: ${{ secrets.CERTIFICATE_PASSWORD }}
-
+      - name: Cache npm dependencies
+        uses: actions/cache@2f8e54208210a422b2efd51efaa6bd6d7ca8920f # pin@v3
+        with:
+          path: |
+            ui/desktop/node_modules
+            .hermit/node/cache
+          key: intel-npm-cache-v1-${{ runner.os }}-${{ hashFiles('ui/desktop/package-lock.json') }}
+          restore-keys: |
+            intel-npm-cache-v1-${{ runner.os }}-
+
       - name: Install dependencies
         run: source ../../bin/activate-hermit && npm ci
         working-directory: ui/desktop
@@ -208,8 +159,7 @@ jobs:
       - name: Check disk space before bundling
         run: df -h
 
-      - name: Make Unsigned App
-        if: ${{ !inputs.signing }}
+      - name: Build App
         run: |
           source ../../bin/activate-hermit
           attempt=0
@@ -226,27 +176,79 @@ jobs:
           fi
         working-directory: ui/desktop
 
-      - name: Make Signed App
+      - name: Configure AWS credentials
+        if: ${{ inputs.signing }}
+        uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4
+        with:
+          role-to-assume: "${{ secrets.OSX_CODESIGN_ROLE }}"
+          aws-region: us-west-2
+
+      - name: Codesigning and Notarization
         if: ${{ inputs.signing }}
         run: |
-          source ../../bin/activate-hermit
-          attempt=0
-          max_attempts=2
-          until [ $attempt -ge $max_attempts ]; do
-            npm run bundle:intel && break
-            attempt=$((attempt + 1))
-            echo "Attempt $attempt failed. Retrying..."
-            sleep 5
-          done
-          if [ $attempt -ge $max_attempts ]; then
-            echo "Action failed after $max_attempts attempts."
+          set -e
+
+          echo "⬆️ uploading unsigned app"
+          source_job_url="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
+          unsigned_url="s3://block-goose-artifacts-bucket-production/unsigned/goose-${GITHUB_SHA}-${{ github.run_id }}-intel.zip"
+
+          zip -q -u -r out/Goose-darwin-x64/Goose_intel_mac.zip entitlements.plist
+
+          # upload unsigned goose to transfer bucket so it can be passed to lambda
+          aws s3 cp --quiet out/Goose-darwin-x64/Goose_intel_mac.zip "${unsigned_url}"
+
+          # begin signing
+          echo "🚀 launching signing process"
+          aws lambda invoke \
+            --function-name codesign_helper \
+            --cli-binary-format raw-in-base64-out \
+            --payload "{\"source_s3_url\": \"${unsigned_url}\", \"source_job_url\": \"${source_job_url}\"}" \
+            response.json > /dev/null
+
+          if [ "$(jq -r .statusCode response.json)" != "200" ]; then
+            echo "⚠️ lambda function did not return expected status code"
             exit 1
           fi
+
+          build_number="$(jq -r .body.build_number response.json)"
+
+          start_time=$(date +%s)
+
+          while sleep 30; do
+            aws lambda invoke \
+              --function-name codesign_helper \
+              --cli-binary-format raw-in-base64-out \
+              --payload "{\"source_s3_url\": \"${unsigned_url}\", \"build_number\": \"${build_number}\"}" \
+              response.json > /dev/null
+
+            if [ "$(jq -r .statusCode response.json)" != "200" ]; then
+              echo "⚠️ signing request returned unexpected response code $(jq -r .statusCode response.json):"
+              jq . response.json
+              exit 1
+            fi
+
+            state="$(jq -r .body.state response.json)"
+
+            if [ "${state}" == "completed" ]; then
+              echo "✅ signing complete ($(($(date +%s) - start_time))s)"
+              break
+            fi
+
+            if [ $(($(date +%s) - start_time)) -ge 3600 ]; then
+              echo "⚠️ timed out ($(($(date +%s) - start_time))s)"
+              exit 1
+            fi
+
+            echo "⏲️ waiting for signing to complete (${state}: $(($(date +%s) - start_time))s)"
+          done
+
+          # parse lambda response
+          signed_url=$(jq -r .body.destination_url response.json)
+
+          # download the signed app from S3
+          echo "⬇️ downloading signed app"
+          aws s3 cp --quiet "${signed_url}" out/Goose-darwin-x64/Goose_intel_mac.zip
         working-directory: ui/desktop
-        env:
-          APPLE_ID: ${{ secrets.APPLE_ID }}
-          APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
-          APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
 
       - name: Final cleanup before artifact upload
         run: |