discord: Add StringOption Min/MaxLength #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this is necessary. Min and Max makes perfect sense given an integer/number type. |
twoscott
force-pushed
the
string-option-length-limits
branch
from
8e894c7 to
f62a501
Compare
|
That's true, amended in f62a501. |
diamondburned
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Min/MaxLength fields for
StringOption, documented here. Min/Max fields forIntegerOptionandNumberOptionwere also renamed to Min/MaxValue to differentiate better between...Valueand...Lengthfields. This is breaking but makes them more accurate to the API and there may be breaking changes in #353 anyway.