Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SpeakerTextbox style and layer #2341

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Improve SpeakerTextbox style and layer #2341

merged 2 commits into from
Jul 12, 2024

Conversation

Jowan-Spooner
Copy link
Member

Style

  • the input catcher is now behind the textbox by default

Layer:

  • the textbox root setting is correctly setup (previously the hide_textbox setting on the wait/wait_input event didn't work)
  • nothing except the text blocks the input now.

@Jowan-Spooner
Improve SpeakerTextbox layer
8e785ea 
- makes it not block the mouse
- sets the textbox_root property correctly on the DialogText node
@Jowan-Spooner
SpeakerTextboxStyle: move input catcher behind the textbox
7a8ad2c 
This is now the recommended way to do it, so the default should do it too.
@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Enhance ⚡ Improve a feature's workflow. labels Jul 11, 2024
@Jowan-Spooner Jowan-Spooner merged commit a964273 into dialogic-godot:main Jul 12, 2024
2 checks passed
@Jowan-Spooner Jowan-Spooner deleted the improve-speaker-textbox-layer branch July 13, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug 🐞 Something isn't working Enhance ⚡ Improve a feature's workflow.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jowan-Spooner